mudhorn/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2025-02-02 08:31:11 -08:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

Fix deadlock with empty MemPostings

Browse source 
Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
This commit is contained in:
Oleg Zaytsev 2024-09-25 14:08:50 +02:00
parent e196b977af
commit 9c417aa710
No known key found for this signature in database
GPG key ID: 7E9FE9FD48F512EF
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
tsdb/index/postings.go
View file

@ -295,7 +295,8 @@ func (p *MemPostings) Delete(deleted map[storage.SeriesRef]struct{}, affected ma
defer p.mtx.Unlock()
// Deleting label names mutates p.m map, so it should be done from a single goroutine after nobody else is reading it.
deleteLabelNames := make(chan string, len(p.m))
// Adding +1 to length to account for allPostingsKey processing when MemPostings is empty.
deleteLabelNames := make(chan string, len(p.m)+1)
process := func(l labels.Label) {
orig := p.m[l.Name][l.Value]