From 9d9c45588e37c87667682e6a75be33dd10b4a2a5 Mon Sep 17 00:00:00 2001 From: Bartlomiej Plotka Date: Fri, 13 Mar 2020 19:18:31 +0000 Subject: [PATCH] Addressed Goutham's review. Signed-off-by: Bartlomiej Plotka --- tsdb/querier.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tsdb/querier.go b/tsdb/querier.go index 4652a3f78f..2a64d57ead 100644 --- a/tsdb/querier.go +++ b/tsdb/querier.go @@ -90,15 +90,15 @@ func (q *querier) Select(sortSeries bool, hints *storage.SelectHints, ms ...*lab return storage.EmptySeriesSet(), nil, nil } if len(q.blocks) == 1 { + // Sorting Head series is slow, and unneeded when only the + // Head is being queried. return q.blocks[0].Select(sortSeries, hints, ms...) } ss := make([]storage.SeriesSet, len(q.blocks)) var ws storage.Warnings for i, b := range q.blocks { - // Sorting Head series is slow, and unneeded when only the - // Head is being queried. Sorting blocks is a noop. - // Still we have to sort if blocks > 1 as MergedSeriesSet requires it. + // We have to sort if blocks > 1 as MergedSeriesSet requires it. s, w, err := b.Select(true, hints, ms...) ws = append(ws, w...) if err != nil {