mudhorn/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2025-03-05 20:59:13 -08:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

Fix TestForStateRestore (#4476) (#4512)

Browse source 
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
This commit is contained in:
Ganesh Vernekar 2018-08-16 19:26:15 +02:00 committed by Goutham Veeramachaneni
parent 71855a22a4
commit a0a9e7df91
1 changed files with 11 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
rules/manager_test.go
View file

@ -326,8 +326,14 @@ func TestForStateAddSamples(t *testing.T) {
} }
} }
func TestForStateRestore(t *testing.T) { // sortAlerts sorts `[]*Alert` w.r.t. the Labels.
func sortAlerts(items []*Alert) {
sort.Slice(items, func(i, j int) bool {
return labels.Compare(items[i].Labels, items[j].Labels) <= 0
})
}
func TestForStateRestore(t *testing.T) {
suite, err := promql.NewTest(t, ` suite, err := promql.NewTest(t, `
load 5m load 5m
http_requests{job="app-server", instance="0", group="canary", severity="overwrite-me"} 75 85 50 0 0 25 0 0 40 0 120 http_requests{job="app-server", instance="0", group="canary", severity="overwrite-me"} 75 85 50 0 0 25 0 0 40 0 120
@ -364,7 +370,6 @@ func TestForStateRestore(t *testing.T) {
) )
group := NewGroup("default", "", time.Second, []Rule{rule}, true, opts) group := NewGroup("default", "", time.Second, []Rule{rule}, true, opts)
groups := make(map[string]*Group) groups := make(map[string]*Group)
groups["default;"] = group groups["default;"] = group
@ -385,7 +390,6 @@ func TestForStateRestore(t *testing.T) {
}) })
// Prometheus goes down here. We create new rules and groups. // Prometheus goes down here. We create new rules and groups.
type testInput struct { type testInput struct {
restoreDuration time.Duration restoreDuration time.Duration
alerts []*Alert alerts []*Alert
@ -399,9 +403,9 @@ func TestForStateRestore(t *testing.T) {
tests := []testInput{ tests := []testInput{
{ {
// Normal restore (alerts were not firing). // Normal restore (alerts were not firing).
restoreDuration: 10 * time.Minute, restoreDuration: 15 * time.Minute,
alerts: rule.ActiveAlerts(), alerts: rule.ActiveAlerts(),
downDuration: 5 * time.Minute, downDuration: 10 * time.Minute,
}, },
{ {
// Testing Outage Tolerance. // Testing Outage Tolerance.
@ -449,7 +453,6 @@ func TestForStateRestore(t *testing.T) {
}) })
// Checking if we have restored it correctly. // Checking if we have restored it correctly.
if tst.noRestore { if tst.noRestore {
testutil.Equals(t, tst.num, len(got)) testutil.Equals(t, tst.num, len(got))
for _, e := range got { for _, e := range got {
@ -463,6 +466,8 @@ func TestForStateRestore(t *testing.T) {
} else { } else {
exp := tst.alerts exp := tst.alerts
testutil.Equals(t, len(exp), len(got)) testutil.Equals(t, len(exp), len(got))
sortAlerts(exp)
sortAlerts(got)
for i, e := range exp { for i, e := range exp {
testutil.Equals(t, e.Labels, got[i].Labels) testutil.Equals(t, e.Labels, got[i].Labels)