mudhorn/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2025-03-05 20:59:13 -08:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

Migrate last IndexWriter pieces to decbuf

Browse source
This commit is contained in:
Fabian Reinartz 2017-04-26 20:32:34 +02:00
parent 94f3fd9812
commit a54f46d5e7
3 changed files with 17 additions and 39 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Documentation/format/index.md
View file

@ -194,5 +194,7 @@ The table of contents serves as an entry point to the entire index. It's size is
│ ref(postings) <8 byte> │ │ ref(postings) <8 byte> │
├─────────────────────────────────────────────┤ ├─────────────────────────────────────────────┤
│ ref(postings table) <8 byte> │ │ ref(postings table) <8 byte> │
├─────────────────────────────────────────────┤
│ CRC32 <4 byte> │
└─────────────────────────────────────────────┘ └─────────────────────────────────────────────┘
``` ```

2
encoding_helpers.go
View file

@ -83,7 +83,7 @@ func (d *decbuf) uvarintStr() string {
d.e = errInvalidSize d.e = errInvalidSize
return "" return ""
} }
s := string(d.b[:l]) s := yoloString(d.b[:l])
d.b = d.b[l:] d.b = d.b[l:]
return s return s
} }

52
index.go
View file

@ -636,36 +636,13 @@ func (r *indexReader) section(o uint32) (byte, []byte, error) {
} }
func (r *indexReader) lookupSymbol(o uint32) (string, error) { func (r *indexReader) lookupSymbol(o uint32) (string, error) {
if int(o) > len(r.b) { d := r.decbufAt(int(o))
return "", errors.Errorf("invalid symbol offset %d", o)
}
l, n := binary.Uvarint(r.b[o:])
if n < 0 {
return "", errors.New("reading symbol length failed")
}
end := int(o) + n + int(l) s := d.uvarintStr()
if end > len(r.b) { if d.err() != nil {
return "", errors.Errorf("invalid length %d", l) return "", errors.Wrapf(d.err(), "read symbol at %d", o)
} }
b := r.b[int(o)+n : end] return s, nil
return yoloString(b), nil
}
func (r *indexReader) getSized(off uint32) ([]byte, error) {
if int(off) > len(r.b) {
return nil, errInvalidSize
}
b := r.b[off:]
l, n := binary.Uvarint(b)
if n < 1 {
return nil, errInvalidSize
}
if int(l) > len(b[n:]) {
return nil, errInvalidSize
}
return b[n : n+int(l)], nil
} }
func (r *indexReader) LabelValues(names ...string) (StringTuples, error) { func (r *indexReader) LabelValues(names ...string) (StringTuples, error) {
@ -770,24 +747,23 @@ func (r *indexReader) Series(ref uint32) (labels.Labels, []*ChunkMeta, error) {
func (r *indexReader) Postings(name, value string) (Postings, error) { func (r *indexReader) Postings(name, value string) (Postings, error) {
const sep = "\xff" const sep = "\xff"
key := strings.Join([]string{name, value}, sep)
key := name + string(sep) + value
off, ok := r.postings[key] off, ok := r.postings[key]
if !ok { if !ok {
return emptyPostings, nil return emptyPostings, nil
} }
b, err := r.getSized(off) d1 := r.decbufAt(int(off))
if err != nil { d2 := d1.decbuf(d1.uvarint())
return nil, errors.Wrapf(err, "get sized region at %d", off)
} if d2.err() != nil {
// Add iterator over the bytes. return nil, errors.Wrap(d2.err(), "get postings bytes")
if len(b)%4 != 0 {
return nil, errors.Wrap(errInvalidSize, "plain postings entry")
} }
return newBigEndianPostings(b), nil // TODO(fabxc): read checksum from 4 remainer bytes of d1 and verify.
return newBigEndianPostings(d2.get()), nil
} }
type stringTuples struct { type stringTuples struct {