mudhorn/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2025-03-05 20:59:13 -08:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

digitalocean: use a safer pagination method (#7498)

Browse source 
this method is documented here: https://github.com/digitalocean/godo

Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
This commit is contained in:
Julien Pivotto 2020-07-02 00:13:39 +02:00 committed by GitHub
parent 578f2b7974
commit aa452d8ab4
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
discovery/digitalocean/digitalocean.go
View file

@ -176,7 +176,7 @@ func (d *Discovery) refresh(ctx context.Context) ([]*targetgroup.Group, error) {
func (d *Discovery) listDroplets() ([]godo.Droplet, error) { func (d *Discovery) listDroplets() ([]godo.Droplet, error) {
var ( var (
droplets []godo.Droplet droplets []godo.Droplet
opts = &godo.ListOptions{Page: 1} opts = &godo.ListOptions{}
) )
for { for {
paginatedDroplets, resp, err := d.client.Droplets.List(context.Background(), opts) paginatedDroplets, resp, err := d.client.Droplets.List(context.Background(), opts)
@ -187,7 +187,13 @@ func (d *Discovery) listDroplets() ([]godo.Droplet, error) {
if resp.Links == nil || resp.Links.IsLastPage() { if resp.Links == nil || resp.Links.IsLastPage() {
break break
} }
opts.Page++
page, err := resp.Links.CurrentPage()
if err != nil {
return nil, err
}
opts.Page = page + 1
} }
return droplets, nil return droplets, nil
} }