mudhorn/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2025-03-05 20:59:13 -08:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

Add warning log for same labelset after relabeling

Browse source 
Signed-off-by: darshanime <deathbullet@gmail.com>
This commit is contained in:
darshanime 2024-01-25 19:50:28 +05:30
parent a441ad771e
commit ad69899407
2 changed files with 17 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
discovery/targetgroup/targetgroup.go
View file

@ -20,7 +20,7 @@ import (
"github.com/prometheus/common/model" "github.com/prometheus/common/model"
) )
// Group is a set of targets with a common label set(production , test, staging etc.). // Group is a set of targets with a common label set(production, test, staging etc).
type Group struct { type Group struct {
// Targets is a list of targets identified by a label set. Each target is // Targets is a list of targets identified by a label set. Each target is
// uniquely identifiable in the group by its address label. // uniquely identifiable in the group by its address label.

16
scrape/manager.go
View file

@ -197,6 +197,7 @@ func (m *Manager) reload() {
} }
wg.Add(1) wg.Add(1)
// Run the sync in parallel as these take a while and at high load can't catch up. // Run the sync in parallel as these take a while and at high load can't catch up.
go func(sp *scrapePool, groups []*targetgroup.Group) { go func(sp *scrapePool, groups []*targetgroup.Group) {
sp.Sync(groups) sp.Sync(groups)
@ -205,6 +206,21 @@ func (m *Manager) reload() {
} }
m.mtxScrape.Unlock() m.mtxScrape.Unlock()
wg.Wait() wg.Wait()
activeTargets := make(map[uint64]*Target)
for _, scrapePool := range m.scrapePools {
for _, target := range scrapePool.activeTargets {
if t, ok := activeTargets[target.labels.Hash()]; ok {
level.Warn(m.logger).Log(
"msg", "Found targets with same labels after relabelling",
"target", t.URL().String(),
"target", target.URL().String(),
)
}
activeTargets[target.labels.Hash()] = target
}
}
} }
// setOffsetSeed calculates a global offsetSeed per server relying on extra label set. // setOffsetSeed calculates a global offsetSeed per server relying on extra label set.