mudhorn/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2025-02-02 08:31:11 -08:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

forbid unexpected (runtime) errors in parse tests

Browse source
This commit is contained in:
Fabian Reinartz 2015-08-03 12:53:31 +02:00
parent c20e25f718
commit adf109795c
2 changed files with 36 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
promql/parse.go
View file

@ -321,6 +321,8 @@ func (p *parser) expectOneOf(exp1, exp2 itemType, context string) item {
return token return token
} }
var errUnexpected = fmt.Errorf("unexpected error")
// recover is the handler that turns panics into returns from the top level of Parse. // recover is the handler that turns panics into returns from the top level of Parse.
func (p *parser) recover(errp *error) { func (p *parser) recover(errp *error) {
e := recover() e := recover()
@ -331,7 +333,7 @@ func (p *parser) recover(errp *error) {
buf = buf[:runtime.Stack(buf, false)] buf = buf[:runtime.Stack(buf, false)]
log.Errorf("parser panic: %v\n%s", e, buf) log.Errorf("parser panic: %v\n%s", e, buf)
*errp = fmt.Errorf("unexpected error") *errp = errUnexpected
} else { } else {
*errp = e.(error) *errp = e.(error)
} }

35
promql/parse_test.go
View file

@ -973,6 +973,12 @@ func TestParseExpressions(t *testing.T) {
parser := newParser(test.input) parser := newParser(test.input)
expr, err := parser.parseExpr() expr, err := parser.parseExpr()
// Unexpected errors are always caused by a bug.
if err == errUnexpected {
t.Fatalf("unexpected error occurred")
}
if !test.fail && err != nil { if !test.fail && err != nil {
t.Errorf("error in input '%s'", test.input) t.Errorf("error in input '%s'", test.input)
t.Fatalf("could not parse: %s", err) t.Fatalf("could not parse: %s", err)
@ -1219,6 +1225,19 @@ var testStatement = []struct {
`, `,
fail: true, fail: true,
}, },
// Fuzzing regression tests.
{
input: `I=-/`,
fail: true,
},
{
input: `I=3E8/-=`,
fail: true,
},
{
input: `M=-=-0-0`,
fail: true,
},
} }
func TestParseStatements(t *testing.T) { func TestParseStatements(t *testing.T) {
@ -1226,6 +1245,12 @@ func TestParseStatements(t *testing.T) {
parser := newParser(test.input) parser := newParser(test.input)
stmts, err := parser.parseStmts() stmts, err := parser.parseStmts()
// Unexpected errors are always caused by a bug.
if err == errUnexpected {
t.Fatalf("unexpected error occurred")
}
if !test.fail && err != nil { if !test.fail && err != nil {
t.Errorf("error in input: \n\n%s\n", test.input) t.Errorf("error in input: \n\n%s\n", test.input)
t.Fatalf("could not parse: %s", err) t.Fatalf("could not parse: %s", err)
@ -1353,6 +1378,12 @@ func TestParseSeries(t *testing.T) {
parser.lex.seriesDesc = true parser.lex.seriesDesc = true
metric, vals, err := parser.parseSeriesDesc() metric, vals, err := parser.parseSeriesDesc()
// Unexpected errors are always caused by a bug.
if err == errUnexpected {
t.Fatalf("unexpected error occurred")
}
if !test.fail && err != nil { if !test.fail && err != nil {
t.Errorf("error in input: \n\n%s\n", test.input) t.Errorf("error in input: \n\n%s\n", test.input)
t.Fatalf("could not parse: %s", err) t.Fatalf("could not parse: %s", err)
@ -1385,8 +1416,8 @@ func TestRecoverRuntime(t *testing.T) {
var a []int var a []int
a[123] = 1 a[123] = 1
if err.Error() != "unexpected error" { if err != errUnexpected {
t.Fatalf("wrong error message: %q, expected %q", err, "unexpected error") t.Fatalf("wrong error message: %q, expected %q", err, errUnexpected)
} }
} }