mudhorn/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2024-11-10 07:34:04 -08:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

Review feedback.

Browse source 
Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
This commit is contained in:
Tom Wilkie 2018-05-29 11:35:43 +01:00
parent 3353bbd018
commit b58199bf12
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
storage/remote/client_test.go
View file

@ -74,7 +74,7 @@ func TestStoreHTTPErrorHandling(t *testing.T) {
t.Fatal(err) t.Fatal(err)
} }
err = c.Store(context.TODO(), &prompb.WriteRequest{}) err = c.Store(context.Background(), &prompb.WriteRequest{})
if !reflect.DeepEqual(err, test.err) { if !reflect.DeepEqual(err, test.err) {
t.Errorf("%d. Unexpected error; want %v, got %v", i, test.err, err) t.Errorf("%d. Unexpected error; want %v, got %v", i, test.err, err)
} }

2
storage/remote/queue_manager.go
View file

@ -420,7 +420,7 @@ func (s *shards) stop(deadline time.Duration) {
level.Error(s.qm.logger).Log("msg", "Failed to flush all samples on shutdown") level.Error(s.qm.logger).Log("msg", "Failed to flush all samples on shutdown")
} }
// Force a unclean shutdown. // Force an unclean shutdown.
s.cancel() s.cancel()
<-s.done <-s.done
return return