mudhorn/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2025-01-29 06:30:51 -08:00
Code Issues Actions 14 Packages Projects Releases Wiki Activity

Merge pull request #12903 from roidelapluie/fix-pr-7023

Browse source 
rulefmt: remove unreachable code
This commit is contained in:
Julien Pivotto 2023-09-29 18:20:40 +02:00 committed by GitHub
parent 77bc6b01f0 c52db2b196
commit b6dbfcc15f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
model/rulefmt/rulefmt.go
View file

@ -173,17 +173,11 @@ func (r *RuleNode) Validate() (nodes []WrappedError) {
})
}
if r.Record.Value == "" && r.Alert.Value == "" {
if r.Record.Value == "0" {
nodes = append(nodes, WrappedError{
err: fmt.Errorf("one of 'record' or 'alert' must be set"),
node: &r.Alert,
})
} else {
nodes = append(nodes, WrappedError{
err: fmt.Errorf("one of 'record' or 'alert' must be set"),
node: &r.Record,
})
}
nodes = append(nodes, WrappedError{
err: fmt.Errorf("one of 'record' or 'alert' must be set"),
node: &r.Record,
nodeAlt: &r.Alert,
})
}
if r.Expr.Value == "" {