From bc6fd969796bafe4ea4e1069ebe5e2579d897fc0 Mon Sep 17 00:00:00 2001 From: Ganesh Vernekar Date: Thu, 6 Feb 2020 18:25:00 +0530 Subject: [PATCH] Refactor TestGCChunkAccess and TestGCSeriesAccess to create chunks by appending samples Signed-off-by: Ganesh Vernekar --- tsdb/head_test.go | 40 ++++++++++++++++++++++++++++++++-------- 1 file changed, 32 insertions(+), 8 deletions(-) diff --git a/tsdb/head_test.go b/tsdb/head_test.go index d63e289156..93006e3210 100644 --- a/tsdb/head_test.go +++ b/tsdb/head_test.go @@ -959,10 +959,22 @@ func TestGCChunkAccess(t *testing.T) { h.initTime(0) s, _ := h.getOrCreate(1, labels.FromStrings("a", "1")) - s.chunks = []*memChunk{ - {minTime: 0, maxTime: 999}, - {minTime: 1000, maxTime: 1999}, - } + + // Appending 2 samples for the first chunk. + ok, chunkCreated := s.append(0, 0) + testutil.Assert(t, ok, "series append failed") + testutil.Assert(t, chunkCreated, "chunks was not created") + ok, chunkCreated = s.append(999, 999) + testutil.Assert(t, ok, "series append failed") + testutil.Assert(t, !chunkCreated, "chunks was created") + + // A new chunks should be created here as it's beyond the chunk range. + ok, chunkCreated = s.append(1000, 1000) + testutil.Assert(t, ok, "series append failed") + testutil.Assert(t, chunkCreated, "chunks was not created") + ok, chunkCreated = s.append(1999, 1999) + testutil.Assert(t, ok, "series append failed") + testutil.Assert(t, !chunkCreated, "chunks was created") idx := h.indexRange(0, 1500) var ( @@ -999,10 +1011,22 @@ func TestGCSeriesAccess(t *testing.T) { h.initTime(0) s, _ := h.getOrCreate(1, labels.FromStrings("a", "1")) - s.chunks = []*memChunk{ - {minTime: 0, maxTime: 999}, - {minTime: 1000, maxTime: 1999}, - } + + // Appending 2 samples for the first chunk. + ok, chunkCreated := s.append(0, 0) + testutil.Assert(t, ok, "series append failed") + testutil.Assert(t, chunkCreated, "chunks was not created") + ok, chunkCreated = s.append(999, 999) + testutil.Assert(t, ok, "series append failed") + testutil.Assert(t, !chunkCreated, "chunks was created") + + // A new chunks should be created here as it's beyond the chunk range. + ok, chunkCreated = s.append(1000, 1000) + testutil.Assert(t, ok, "series append failed") + testutil.Assert(t, chunkCreated, "chunks was not created") + ok, chunkCreated = s.append(1999, 1999) + testutil.Assert(t, ok, "series append failed") + testutil.Assert(t, !chunkCreated, "chunks was created") idx := h.indexRange(0, 2000) var (