mudhorn/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2024-11-09 23:24:05 -08:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

Fix two bugs in range op time advancement.

Browse source
This commit is contained in:
Julius Volz 2013-03-21 17:52:16 +01:00
parent c11737c5fc
commit becc278eb6
1 changed files with 8 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
storage/metric/operation.go
View file

@ -215,7 +215,10 @@ func (g *getValuesAlongRangeOp) ExtractSamples(in []model.SamplePair) (out []mod
return !in[i].Timestamp.Before(g.from) return !in[i].Timestamp.Before(g.from)
}) })
if firstIdx == len(in) { if firstIdx == len(in) {
// No samples at or after operator start time. // No samples at or after operator start time. This can only happen if we
// try applying the operator to a time after the last recorded sample. In
// this case, we're finished.
g.from = g.through.Add(1)
return return
} }
@ -228,7 +231,10 @@ func (g *getValuesAlongRangeOp) ExtractSamples(in []model.SamplePair) (out []mod
} }
lastSampleTime := in[lastIdx-1].Timestamp lastSampleTime := in[lastIdx-1].Timestamp
g.from = lastSampleTime.Add(time.Duration(1)) // Sample times are stored with a maximum time resolution of one second, so
// we have to add exactly that to target the next chunk on the next op
// iteration.
g.from = lastSampleTime.Add(time.Second)
return in[firstIdx:lastIdx] return in[firstIdx:lastIdx]
} }