mudhorn/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2025-03-05 20:59:13 -08:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

Merge pull request #552 from grafana/arve/improve-cache-tests

Browse source 
PostingsForMatchersCache test improvements
This commit is contained in:
Arve Knudsen 2023-10-25 08:07:06 +02:00 committed by GitHub
parent b01b1b7042 6a4a87271b
commit bfc49c1f3d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
tsdb/postings_for_matchers_cache_test.go
View file

@ -44,7 +44,7 @@ func TestPostingsForMatchersCache(t *testing.T) {
p, err := c.PostingsForMatchers(ctx, indexForPostingsMock{}, concurrent, expectedMatchers...) p, err := c.PostingsForMatchers(ctx, indexForPostingsMock{}, concurrent, expectedMatchers...)
require.NoError(t, err) require.NoError(t, err)
require.NotNil(t, p) require.NotNil(t, p)
require.Equal(t, p.Err(), expectedPostingsErr, "Expected ErrPostings with err %q, got %T with err %q", expectedPostingsErr, p, p.Err()) require.Equal(t, expectedPostingsErr, p.Err(), "Expected ErrPostings with err %q, got %T with err %q", expectedPostingsErr, p, p.Err())
}) })
} }
}) })
@ -93,7 +93,7 @@ func TestPostingsForMatchersCache(t *testing.T) {
expectedResults[i] = c[0].String() expectedResults[i] = c[0].String()
} }
expectedPostingsForMatchersCalls := 5 const expectedPostingsForMatchersCalls = 5
// we'll block all the calls until we receive the exact amount. if we receive more, WaitGroup will panic // we'll block all the calls until we receive the exact amount. if we receive more, WaitGroup will panic
called := make(chan struct{}, expectedPostingsForMatchersCalls) called := make(chan struct{}, expectedPostingsForMatchersCalls)
release := make(chan struct{}) release := make(chan struct{})
@ -327,7 +327,7 @@ func TestPostingsForMatchersCache(t *testing.T) {
require.Equal(t, refsLists[matchersKey(matchers)], actual) require.Equal(t, refsLists[matchersKey(matchers)], actual)
} }
// To ensure the 1st (oldest) entry was removed, we call PostingsForMatchers() again on that matchers. // To ensure the 1st (oldest) entry was removed, we call PostingsForMatchers() again on those matchers.
_, err := c.PostingsForMatchers(ctx, indexForPostingsMock{}, true, matchersLists[0]...) _, err := c.PostingsForMatchers(ctx, indexForPostingsMock{}, true, matchersLists[0]...)
require.NoError(t, err) require.NoError(t, err)