mudhorn/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2024-12-26 22:19:40 -08:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

Fix discovery managers to be properly cancelled

Browse source 
Signed-off-by: Jinwook Jeong <vustthat@gmail.com>
This commit is contained in:
Jinwook Jeong 2022-04-09 01:03:54 +09:00
parent 6555cc68ca
commit c7c7847b6f
2 changed files with 6 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
discovery/legacymanager/manager.go
View file

@ -140,11 +140,9 @@ type Manager struct {
// Run starts the background processing // Run starts the background processing
func (m *Manager) Run() error { func (m *Manager) Run() error {
go m.sender() go m.sender()
for range m.ctx.Done() { <-m.ctx.Done()
m.cancelDiscoverers() m.cancelDiscoverers()
return m.ctx.Err() return m.ctx.Err()
}
return nil
} }
// SyncCh returns a read only channel used by all the clients to receive target updates. // SyncCh returns a read only channel used by all the clients to receive target updates.

4
discovery/manager.go
View file

@ -166,11 +166,9 @@ type Manager struct {
// Run starts the background processing. // Run starts the background processing.
func (m *Manager) Run() error { func (m *Manager) Run() error {
go m.sender() go m.sender()
for range m.ctx.Done() { <-m.ctx.Done()
m.cancelDiscoverers() m.cancelDiscoverers()
return m.ctx.Err() return m.ctx.Err()
}
return nil
} }
// SyncCh returns a read only channel used by all the clients to receive target updates. // SyncCh returns a read only channel used by all the clients to receive target updates.