mudhorn/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2025-03-05 20:59:13 -08:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

web: use t.TempDir instead of ioutil.TempDir on tests (#9981)

Browse source 
Signed-off-by: Matheus Alcantara <matheusssilv97@gmail.com>
This commit is contained in:
Matheus Alcantara 2021-12-08 19:14:50 -03:00 committed by GitHub
parent 05d4d97bcd
commit c965a7555b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
web/api/v1/api_test.go
View file

@ -407,9 +407,7 @@ func TestEndpoints(t *testing.T) {
Format: &af, Format: &af,
} }
dbDir, err := ioutil.TempDir("", "tsdb-api-ready") dbDir := t.TempDir()
require.NoError(t, err)
defer os.RemoveAll(dbDir)
remote := remote.NewStorage(promlog.New(&promlogConfig), prometheus.DefaultRegisterer, func() (int64, error) { remote := remote.NewStorage(promlog.New(&promlogConfig), prometheus.DefaultRegisterer, func() (int64, error) {
return 0, nil return 0, nil
@ -2344,8 +2342,7 @@ func TestAdminEndpoints(t *testing.T) {
} { } {
tc := tc tc := tc
t.Run("", func(t *testing.T) { t.Run("", func(t *testing.T) {
dir, _ := ioutil.TempDir("", "fakeDB") dir := t.TempDir()
defer func() { require.NoError(t, os.RemoveAll(dir)) }()
api := &API{ api := &API{
db: tc.db, db: tc.db,

12
web/web_test.go
View file

@ -112,9 +112,7 @@ func (a *dbAdapter) WALReplayStatus() (tsdb.WALReplayStatus, error) {
func TestReadyAndHealthy(t *testing.T) { func TestReadyAndHealthy(t *testing.T) {
t.Parallel() t.Parallel()
dbDir, err := ioutil.TempDir("", "tsdb-ready") dbDir := t.TempDir()
require.NoError(t, err)
defer func() { require.NoError(t, os.RemoveAll(dbDir)) }()
db, err := tsdb.Open(dbDir, nil, nil, nil, nil) db, err := tsdb.Open(dbDir, nil, nil, nil, nil)
require.NoError(t, err) require.NoError(t, err)
@ -235,9 +233,7 @@ func TestReadyAndHealthy(t *testing.T) {
func TestRoutePrefix(t *testing.T) { func TestRoutePrefix(t *testing.T) {
t.Parallel() t.Parallel()
dbDir, err := ioutil.TempDir("", "tsdb-ready") dbDir := t.TempDir()
require.NoError(t, err)
defer func() { require.NoError(t, os.RemoveAll(dbDir)) }()
db, err := tsdb.Open(dbDir, nil, nil, nil, nil) db, err := tsdb.Open(dbDir, nil, nil, nil, nil)
require.NoError(t, err) require.NoError(t, err)
@ -404,9 +400,7 @@ func TestHTTPMetrics(t *testing.T) {
} }
func TestShutdownWithStaleConnection(t *testing.T) { func TestShutdownWithStaleConnection(t *testing.T) {
dbDir, err := ioutil.TempDir("", "tsdb-ready") dbDir := t.TempDir()
require.NoError(t, err)
defer func() { require.NoError(t, os.RemoveAll(dbDir)) }()
db, err := tsdb.Open(dbDir, nil, nil, nil, nil) db, err := tsdb.Open(dbDir, nil, nil, nil, nil)
require.NoError(t, err) require.NoError(t, err)