mudhorn/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2024-11-10 07:34:04 -08:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

Fix possible memory leak by defer inside loop

Browse source
This commit is contained in:
huydx 2016-11-14 00:45:51 +09:00
parent e193579df8
commit c999902761
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
storage/local/crashrecovery.go
View file

@ -62,9 +62,9 @@ func (p *persistence) recoverFromCrash(fingerprintToSeries map[model.Fingerprint
if err != nil { if err != nil {
return err return err
} }
defer dir.Close()
for fis := []os.FileInfo{}; err != io.EOF; fis, err = dir.Readdir(1024) { for fis := []os.FileInfo{}; err != io.EOF; fis, err = dir.Readdir(1024) {
if err != nil { if err != nil {
dir.Close()
return err return err
} }
for _, fi := range fis { for _, fi := range fis {
@ -78,6 +78,7 @@ func (p *persistence) recoverFromCrash(fingerprintToSeries map[model.Fingerprint
} }
} }
} }
dir.Close()
} }
log.Infof("File scan complete. %d series found.", len(fpsSeen)) log.Infof("File scan complete. %d series found.", len(fpsSeen))