Merge pull request #660 from YaoZengzeng/fix

enhancement: flush the page more precisely
This commit is contained in:
Ganesh Vernekar 2019-08-06 15:38:37 +05:30 committed by GitHub
commit ccdf2f7d94
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -631,17 +631,21 @@ func (w *WAL) log(rec []byte, final bool) error {
copy(buf[recordHeaderSize:], part) copy(buf[recordHeaderSize:], part)
p.alloc += len(part) + recordHeaderSize p.alloc += len(part) + recordHeaderSize
// By definition when a record is split it means its size is bigger than if w.page.full() {
// the page boundary so the current page would be full and needs to be flushed. if err := w.flushPage(true); err != nil {
// On contrary if we wrote a full record, we can fit more records of the batch
// into the page before flushing it.
if final || typ != recFull || w.page.full() {
if err := w.flushPage(false); err != nil {
return err return err
} }
} }
rec = rec[l:] rec = rec[l:]
} }
// If it's the final record of the batch and the page is not empty, flush it.
if final && w.page.alloc > 0 {
if err := w.flushPage(false); err != nil {
return err
}
}
return nil return nil
} }