From cd7d0b69a2344d1508d80c68640a0a5381de9cf6 Mon Sep 17 00:00:00 2001 From: Oleg Zaytsev Date: Tue, 1 Aug 2023 14:04:45 +0200 Subject: [PATCH] Check nil err first when committing (#12625) The most common case is to have a nil error when appending series, so let's check that first instead of checking the 3 error types first. Signed-off-by: Oleg Zaytsev --- tsdb/head_append.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tsdb/head_append.go b/tsdb/head_append.go index b981831648..f06aacba44 100644 --- a/tsdb/head_append.go +++ b/tsdb/head_append.go @@ -930,6 +930,8 @@ func (a *headAppender) Commit() (err error) { oooSample, _, err := series.appendable(s.T, s.V, a.headMaxt, a.minValidTime, a.oooTimeWindow) switch err { + case nil: + // Do nothing. case storage.ErrOutOfOrderSample: samplesAppended-- oooRejected++ @@ -939,8 +941,6 @@ func (a *headAppender) Commit() (err error) { case storage.ErrTooOldSample: samplesAppended-- tooOldRejected++ - case nil: - // Do nothing. default: samplesAppended-- }