mudhorn/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2025-03-05 20:59:13 -08:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

Fix BenchmarkOptimizeEqualStringMatchers

Browse source 
The logic has changed, and we create a slice-based matcher for smaller
number of alternations. This fixes the benchmark.

Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
This commit is contained in:
Oleg Zaytsev 2023-10-02 12:00:18 +02:00
parent c7c149e1d9
commit cd91345b76
No known key found for this signature in database
GPG key ID: 7E9FE9FD48F512EF
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
model/labels/regexp_test.go
View file

@ -1183,7 +1183,11 @@ func BenchmarkOptimizeEqualStringMatchers(b *testing.B) {
require.IsType(b, orStringMatcher{}, unoptimized)
optimized := optimizeEqualStringMatchers(unoptimized, 0)
require.IsType(b, &equalMultiStringMapMatcher{}, optimized)
if numAlternations < minEqualMultiStringMatcherMapThreshold {
require.IsType(b, &equalMultiStringSliceMatcher{}, optimized)
} else {
require.IsType(b, &equalMultiStringMapMatcher{}, optimized)
}
b.Run("without optimizeEqualStringMatchers()", func(b *testing.B) {
for n := 0; n < b.N; n++ {