mudhorn/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2025-01-13 14:57:40 -08:00
Code Issues Actions 10 Packages Projects Releases Wiki Activity

TSDB: refine variable naming in chunk gc

Browse source 
Slight further refactor.

Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
This commit is contained in:
Bryan Boreham 2023-10-27 22:02:34 +01:00
parent 071d5732af
commit ce4e757704
1 changed files with 7 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
tsdb/head.go
View file

@ -1779,7 +1779,7 @@ func (s *stripeSeries) gc(mint int64, minOOOMmapRef chunks.ChunkDiskMapperRef) (
minMmapFile = math.MaxInt32 minMmapFile = math.MaxInt32
// For one series, truncate old chunks and check if any chunks left. If not, mark as deleted and collect the ID. // For one series, truncate old chunks and check if any chunks left. If not, mark as deleted and collect the ID.
check := func(i int, hash uint64, series *memSeries, deletedForCallback map[chunks.HeadSeriesRef]labels.Labels) { check := func(hashShard int, hash uint64, series *memSeries, deletedForCallback map[chunks.HeadSeriesRef]labels.Labels) {
series.Lock() series.Lock()
defer series.Unlock() defer series.Unlock()
@ -1820,20 +1820,16 @@ func (s *stripeSeries) gc(mint int64, minOOOMmapRef chunks.ChunkDiskMapperRef) (
// series alike. // series alike.
// If we don't hold them all, there's a very small chance that a series receives // If we don't hold them all, there's a very small chance that a series receives
// samples again while we are half-way into deleting it. // samples again while we are half-way into deleting it.
j := int(series.ref) & (s.size - 1) refShard := int(series.ref) & (s.size - 1)
if hashShard != refShard {
if i != j { s.locks[refShard].Lock()
s.locks[j].Lock() defer s.locks[refShard].Unlock()
} }
deleted[storage.SeriesRef(series.ref)] = struct{}{} deleted[storage.SeriesRef(series.ref)] = struct{}{}
s.hashes[i].del(hash, series.lset) s.hashes[hashShard].del(hash, series.lset)
delete(s.series[j], series.ref) delete(s.series[refShard], series.ref)
deletedForCallback[series.ref] = series.lset deletedForCallback[series.ref] = series.lset
if i != j {
s.locks[j].Unlock()
}
} }
// Run through all series shard by shard, checking which should be deleted. // Run through all series shard by shard, checking which should be deleted.