From cef2e04aa3c97bf30d26b3968e05a22de17e8814 Mon Sep 17 00:00:00 2001
From: Fabian Reinartz <fab.reinartz@gmail.com>
Date: Tue, 6 Dec 2016 16:09:50 +0100
Subject: [PATCH] web: add error counter for federation responses

---
 web/federate.go | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/web/federate.go b/web/federate.go
index 8957152ef1..f910fbab30 100644
--- a/web/federate.go
+++ b/web/federate.go
@@ -18,6 +18,7 @@ import (
 	"sort"
 
 	"github.com/golang/protobuf/proto"
+	"github.com/prometheus/client_golang/prometheus"
 	dto "github.com/prometheus/client_model/go"
 	"github.com/prometheus/common/expfmt"
 	"github.com/prometheus/common/log"
@@ -27,6 +28,13 @@ import (
 	"github.com/prometheus/prometheus/storage/metric"
 )
 
+var (
+	federationErrors = prometheus.NewCounter(prometheus.CounterOpts{
+		Name: "prometheus_web_federation_errors_total",
+		Help: "Total number of errors that occurred while sending federation responses.",
+	})
+)
+
 func (h *Handler) federation(w http.ResponseWriter, req *http.Request) {
 	h.mtx.RLock()
 	defer h.mtx.RUnlock()
@@ -52,6 +60,7 @@ func (h *Handler) federation(w http.ResponseWriter, req *http.Request) {
 
 	q, err := h.storage.Querier()
 	if err != nil {
+		federationErrors.Inc()
 		http.Error(w, err.Error(), http.StatusInternalServerError)
 		return
 	}
@@ -59,6 +68,7 @@ func (h *Handler) federation(w http.ResponseWriter, req *http.Request) {
 
 	vector, err := q.LastSampleForLabelMatchers(h.context, minTimestamp, matcherSets...)
 	if err != nil {
+		federationErrors.Inc()
 		http.Error(w, err.Error(), http.StatusInternalServerError)
 		return
 	}
@@ -92,6 +102,7 @@ func (h *Handler) federation(w http.ResponseWriter, req *http.Request) {
 				// creating the new one.
 				if protMetricFam != nil {
 					if err := enc.Encode(protMetricFam); err != nil {
+						federationErrors.Inc()
 						log.With("err", err).Error("federation failed")
 						return
 					}
@@ -133,6 +144,7 @@ func (h *Handler) federation(w http.ResponseWriter, req *http.Request) {
 	// Still have to ship off the last MetricFamily, if any.
 	if protMetricFam != nil {
 		if err := enc.Encode(protMetricFam); err != nil {
+			federationErrors.Inc()
 			log.With("err", err).Error("federation failed")
 		}
 	}