mudhorn/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2025-03-05 20:59:13 -08:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

Extract to separate method

Browse source 
Signed-off-by: darshanime <deathbullet@gmail.com>
This commit is contained in:
darshanime 2024-01-30 07:47:22 +05:30
parent 49e6bdade5
commit cff15aed86
2 changed files with 16 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
scrape/manager.go
View file

@ -207,14 +207,19 @@ func (m *Manager) reload() {
m.mtxScrape.Unlock() m.mtxScrape.Unlock()
wg.Wait() wg.Wait()
m.warnIfTargetsRelabelledToSameLabels()
}
func (m *Manager) warnIfTargetsRelabelledToSameLabels() {
activeTargets := make(map[uint64]*Target) activeTargets := make(map[uint64]*Target)
for _, scrapePool := range m.scrapePools { for _, scrapePool := range m.scrapePools {
for _, target := range scrapePool.activeTargets { for _, target := range scrapePool.activeTargets {
if t, ok := activeTargets[target.labels.Hash()]; ok { if t, ok := activeTargets[target.labels.Hash()]; ok {
level.Warn(m.logger).Log( level.Warn(m.logger).Log(
"msg", "Found targets with same labels after relabelling", "msg", "Found targets with same labels after relabelling",
"target", t.DiscoveredLabels().Get(model.AddressLabel), "target_one", t.DiscoveredLabels().Get(model.AddressLabel),
"target", target.DiscoveredLabels().Get(model.AddressLabel), "target_two", target.DiscoveredLabels().Get(model.AddressLabel),
"labels", target.labels.String(),
) )
} }
activeTargets[target.labels.Hash()] = target activeTargets[target.labels.Hash()] = target

11
scrape/manager_test.go
View file

@ -638,14 +638,21 @@ func TestManagerDuplicateAfterRelabellingWarning(t *testing.T) {
sp := &scrapePool{ sp := &scrapePool{
activeTargets: map[uint64]*Target{}, activeTargets: map[uint64]*Target{},
} }
sp.activeTargets[uint64(0)] = &Target{discoveredLabels: labels.FromStrings("__address__", "foo")} sp.activeTargets[uint64(0)] = &Target{
sp.activeTargets[uint64(1)] = &Target{discoveredLabels: labels.FromStrings("__address__", "bar")} discoveredLabels: labels.FromStrings("__address__", "foo"),
labels: labels.FromStrings("label_key", "label_value"),
}
sp.activeTargets[uint64(1)] = &Target{
discoveredLabels: labels.FromStrings("__address__", "bar"),
labels: labels.FromStrings("label_key", "label_value"),
}
m.scrapePools["default"] = sp m.scrapePools["default"] = sp
m.reload() m.reload()
require.Contains(t, output, "Found targets with same labels after relabelling") require.Contains(t, output, "Found targets with same labels after relabelling")
require.Contains(t, output, "foo") require.Contains(t, output, "foo")
require.Contains(t, output, "bar") require.Contains(t, output, "bar")
require.Contains(t, output, `{label_key="label_value"}`)
} }
func TestSetOffsetSeed(t *testing.T) { func TestSetOffsetSeed(t *testing.T) {