From d0849f45ffb73c31201b31f71f69296d9ded7a52 Mon Sep 17 00:00:00 2001 From: darshanime Date: Sat, 9 Mar 2024 15:21:18 +0530 Subject: [PATCH] Invert predicate to use !ok Signed-off-by: darshanime --- scrape/manager.go | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/scrape/manager.go b/scrape/manager.go index ef15e647ad..e2dc9198a1 100644 --- a/scrape/manager.go +++ b/scrape/manager.go @@ -214,15 +214,17 @@ func (m *Manager) warnIfTargetsRelabelledToSameLabels() { activeTargets := make(map[uint64]*Target) for _, scrapePool := range m.scrapePools { for _, target := range scrapePool.activeTargets { - if t, ok := activeTargets[target.labels.Hash()]; ok { - level.Warn(m.logger).Log( - "msg", "Found targets with same labels after relabelling", - "target_one", t.DiscoveredLabels().Get(model.AddressLabel), - "target_two", target.DiscoveredLabels().Get(model.AddressLabel), - "labels", target.labels.String(), - ) + t, ok := activeTargets[target.labels.Hash()] + if !ok { + activeTargets[target.labels.Hash()] = target + continue } - activeTargets[target.labels.Hash()] = target + level.Warn(m.logger).Log( + "msg", "Found targets with same labels after relabelling", + "target_one", t.DiscoveredLabels().Get(model.AddressLabel), + "target_two", target.DiscoveredLabels().Get(model.AddressLabel), + "labels", target.labels.String(), + ) } } }