mudhorn/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2025-03-05 20:59:13 -08:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

Merge pull request #1070 from amorken/forgotten-close

Browse source 
Close HTTP connections on HTTP errors too.
This commit is contained in:
Fabian Reinartz 2015-09-11 00:30:54 +02:00
parent 66f376f75a 9fb65a91af
commit d6ed1df4fb
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
retrieval/target.go
View file

@ -437,6 +437,8 @@ func (t *Target) scrape(appender storage.SampleAppender) (err error) {
if err != nil { if err != nil {
return err return err
} }
defer resp.Body.Close()
if resp.StatusCode != http.StatusOK { if resp.StatusCode != http.StatusOK {
return fmt.Errorf("server returned HTTP status %s", resp.Status) return fmt.Errorf("server returned HTTP status %s", resp.Status)
} }
@ -445,7 +447,6 @@ func (t *Target) scrape(appender storage.SampleAppender) (err error) {
if err != nil { if err != nil {
return err return err
} }
defer resp.Body.Close()
sdec := expfmt.SampleDecoder{ sdec := expfmt.SampleDecoder{
Dec: dec, Dec: dec,