From d959d2b90a6f1e24760ab1d47bbf9bf2fcd2933e Mon Sep 17 00:00:00 2001 From: stuart nelson Date: Fri, 6 May 2016 10:46:22 +0200 Subject: [PATCH] discovery/dns: Maintain argument order consistency --- retrieval/discovery/dns/dns.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/retrieval/discovery/dns/dns.go b/retrieval/discovery/dns/dns.go index 8b3f19ca5e..432f1c042b 100644 --- a/retrieval/discovery/dns/dns.go +++ b/retrieval/discovery/dns/dns.go @@ -114,7 +114,7 @@ func (dd *Discovery) refreshAll(ctx context.Context, ch chan<- []*config.TargetG wg.Add(len(dd.names)) for _, name := range dd.names { go func(n string) { - if err := dd.refresh(n, ctx, ch); err != nil { + if err := dd.refresh(ctx, n, ch); err != nil { log.Errorf("Error refreshing DNS targets: %s", err) } wg.Done() @@ -124,7 +124,7 @@ func (dd *Discovery) refreshAll(ctx context.Context, ch chan<- []*config.TargetG wg.Wait() } -func (dd *Discovery) refresh(name string, ctx context.Context, ch chan<- []*config.TargetGroup) error { +func (dd *Discovery) refresh(ctx context.Context, name string, ch chan<- []*config.TargetGroup) error { response, err := lookupAll(name, dd.qtype) dnsSDLookupsCount.Inc() if err != nil {