From dbd29df5df8c623783e756ebd521ec6804ed2541 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C5=81ukasz=20Mierzwa?= Date: Thu, 20 Jun 2024 18:25:44 +0100 Subject: [PATCH] Fix @goyacc invocation (#14324) goyacc is installed using 'install-goyacc' and ends up in GOPATH/bin. GOPATH isn't usually part of standard PATH, so when make tries to run goyacc it fails, unless PATH includes GOPATH/bin. Other Go tools, like golangci-lint, are also installed via go install into GOPATH/bin but they run correctly because make invocations for them use FIRST_GOPATH viriable to use full path. Call goyacc using FIRST_GOPATH/bin as well so it works without GOPATH being included in PATH. Signed-off-by: Lukasz Mierzwa --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 5dcebfd1a..f2bb3fcb7 100644 --- a/Makefile +++ b/Makefile @@ -91,7 +91,7 @@ endif promql/parser/generated_parser.y.go: promql/parser/generated_parser.y @echo ">> running goyacc to generate the .go file." - @goyacc -l -o promql/parser/generated_parser.y.go promql/parser/generated_parser.y + @$(FIRST_GOPATH)/bin/goyacc -l -o promql/parser/generated_parser.y.go promql/parser/generated_parser.y .PHONY: clean-parser clean-parser: