diff --git a/tsdb/querier_bench_test.go b/tsdb/querier_bench_test.go index 206b41fde..e2e281db8 100644 --- a/tsdb/querier_bench_test.go +++ b/tsdb/querier_bench_test.go @@ -31,10 +31,9 @@ const ( ) func BenchmarkQuerier(b *testing.B) { - chunkDir := b.TempDir() opts := DefaultHeadOptions() opts.ChunkRange = 1000 - opts.ChunkDirRoot = chunkDir + opts.ChunkDirRoot = b.TempDir() h, err := NewHead(nil, nil, nil, nil, opts, nil) require.NoError(b, err) defer func() { @@ -58,9 +57,13 @@ func BenchmarkQuerier(b *testing.B) { } require.NoError(b, app.Commit()) - ir, err := h.Index() - require.NoError(b, err) b.Run("Head", func(b *testing.B) { + ir, err := h.Index() + require.NoError(b, err) + defer func() { + require.NoError(b, ir.Close()) + }() + b.Run("PostingsForMatchers", func(b *testing.B) { benchmarkPostingsForMatchers(b, ir) }) @@ -69,18 +72,20 @@ func BenchmarkQuerier(b *testing.B) { }) }) - tmpdir := b.TempDir() - - blockdir := createBlockFromHead(b, tmpdir, h) - block, err := OpenBlock(nil, blockdir, nil) - require.NoError(b, err) - defer func() { - require.NoError(b, block.Close()) - }() - ir, err = block.Index() - require.NoError(b, err) - defer ir.Close() b.Run("Block", func(b *testing.B) { + blockdir := createBlockFromHead(b, b.TempDir(), h) + block, err := OpenBlock(nil, blockdir, nil) + require.NoError(b, err) + defer func() { + require.NoError(b, block.Close()) + }() + + ir, err := block.Index() + require.NoError(b, err) + defer func() { + require.NoError(b, ir.Close()) + }() + b.Run("PostingsForMatchers", func(b *testing.B) { benchmarkPostingsForMatchers(b, ir) }) @@ -239,10 +244,9 @@ func BenchmarkMergedStringIter(b *testing.B) { } func BenchmarkQuerierSelect(b *testing.B) { - chunkDir := b.TempDir() opts := DefaultHeadOptions() opts.ChunkRange = 1000 - opts.ChunkDirRoot = chunkDir + opts.ChunkDirRoot = b.TempDir() h, err := NewHead(nil, nil, nil, nil, opts, nil) require.NoError(b, err) defer h.Close()