mudhorn/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2025-03-05 20:59:13 -08:00
Code Issues Actions 12 Packages Projects Releases Wiki Activity

Fix "instant selector vector" typo in error messages (#8800)

Browse source 
Signed-off-by: Julius Volz <julius.volz@gmail.com>
This commit is contained in:
Julius Volz 2021-05-10 23:33:26 +02:00 committed by GitHub
parent 0a28f1ae9d
commit e313ffa8ab
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
promql/parser/parse.go
View file

@ -703,7 +703,7 @@ func (p *parser) addOffset(e Node, offset time.Duration) {
orgoffsetp = &s.OriginalOffset orgoffsetp = &s.OriginalOffset
endPosp = &s.EndPos endPosp = &s.EndPos
default: default:
p.addParseErrf(e.PositionRange(), "offset modifier must be preceded by an instant selector vector or range vector selector or a subquery") p.addParseErrf(e.PositionRange(), "offset modifier must be preceded by an instant vector selector or range vector selector or a subquery")
return return
} }
@ -778,7 +778,7 @@ func (p *parser) getAtModifierVars(e Node) (**int64, *ItemType, *Pos, bool) {
timestampp = &s.Timestamp timestampp = &s.Timestamp
endPosp = &s.EndPos endPosp = &s.EndPos
default: default:
p.addParseErrf(e.PositionRange(), "@ modifier must be preceded by an instant selector vector or range vector selector or a subquery") p.addParseErrf(e.PositionRange(), "@ modifier must be preceded by an instant vector selector or range vector selector or a subquery")
return nil, nil, nil, false return nil, nil, nil, false
} }

4
promql/parser/parse_test.go
View file

@ -528,7 +528,7 @@ var testExpr = []struct {
}, { }, {
input: "1 offset 1d", input: "1 offset 1d",
fail: true, fail: true,
errMsg: "1:1: parse error: offset modifier must be preceded by an instant selector vector or range vector selector or a subquery", errMsg: "1:1: parse error: offset modifier must be preceded by an instant vector selector or range vector selector or a subquery",
}, { }, {
input: "foo offset 1s offset 2s", input: "foo offset 1s offset 2s",
fail: true, fail: true,
@ -2270,7 +2270,7 @@ var testExpr = []struct {
}, { }, {
input: `rate(some_metric[5m]) @ 1234`, input: `rate(some_metric[5m]) @ 1234`,
fail: true, fail: true,
errMsg: "1:1: parse error: @ modifier must be preceded by an instant selector vector or range vector selector or a subquery", errMsg: "1:1: parse error: @ modifier must be preceded by an instant vector selector or range vector selector or a subquery",
}, },
// Test function calls. // Test function calls.
{ {