mudhorn/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2025-03-05 20:59:13 -08:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

refac: extract skipCTSeries logic from parseMetricSuffix

Browse source 
Signed-off-by: Manik Rana <manikrana54@gmail.com>
This commit is contained in:
Manik Rana 2024-08-06 10:41:51 +05:30
parent af0481f4be
commit e372021a55
1 changed files with 24 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

40
model/textparse/openmetricsparse.go
View file

@ -448,7 +448,8 @@ func (p *OpenMetricsParser) Next() (Entry, error) {
} }
p.series = p.l.b[p.start:p.l.i] p.series = p.l.b[p.start:p.l.i]
return p.parseMetricSuffix(p.nextToken()) suffixEntry, err := p.parseMetricSuffix(p.nextToken())
return p.skipCTParsing(suffixEntry, err)
case tMName: case tMName:
p.offsets = append(p.offsets, p.start, p.l.i) p.offsets = append(p.offsets, p.start, p.l.i)
p.series = p.l.b[p.start:p.l.i] p.series = p.l.b[p.start:p.l.i]
@ -462,7 +463,9 @@ func (p *OpenMetricsParser) Next() (Entry, error) {
p.series = p.l.b[p.start:p.l.i] p.series = p.l.b[p.start:p.l.i]
t2 = p.nextToken() t2 = p.nextToken()
} }
return p.parseMetricSuffix(t2)
suffixEntry, err := p.parseMetricSuffix(t2)
return p.skipCTParsing(suffixEntry, err)
default: default:
err = p.parseError("expected a valid start token", t) err = p.parseError("expected a valid start token", t)
@ -578,6 +581,25 @@ func (p *OpenMetricsParser) parseLVals(offsets []int, isExemplar bool) ([]int, e
} }
} }
// skipCTParsing checks if the current series is a _created series and skips it if necessary.
func (p *OpenMetricsParser) skipCTParsing(e Entry, err error) (Entry, error) {
if e != EntrySeries || !p.skipCTSeries || err != nil {
return e, err
}
var newLbs labels.Labels
p.Metric(&newLbs)
name := newLbs.Get(model.MetricNameLabel)
switch p.mtype {
case model.MetricTypeCounter, model.MetricTypeSummary, model.MetricTypeHistogram:
if strings.HasSuffix(name, "_created") {
return p.Next()
}
default:
break
}
return EntrySeries, nil
}
// parseMetricSuffix parses the end of the line after the metric name and // parseMetricSuffix parses the end of the line after the metric name and
// labels. It starts parsing with the provided token. // labels. It starts parsing with the provided token.
func (p *OpenMetricsParser) parseMetricSuffix(t token) (Entry, error) { func (p *OpenMetricsParser) parseMetricSuffix(t token) (Entry, error) {
@ -623,20 +645,6 @@ func (p *OpenMetricsParser) parseMetricSuffix(t token) (Entry, error) {
} }
} }
if p.skipCTSeries {
var newLbs labels.Labels
p.Metric(&newLbs)
name := newLbs.Get(model.MetricNameLabel)
switch p.mtype {
case model.MetricTypeCounter, model.MetricTypeSummary, model.MetricTypeHistogram:
if strings.HasSuffix(name, "_created") {
return p.Next()
}
default:
break
}
}
return EntrySeries, nil return EntrySeries, nil
} }