From e4037b3ec3654ad9016105e3da80f034a1ad2f5a Mon Sep 17 00:00:00 2001 From: Joshua Hesketh Date: Wed, 5 Feb 2025 22:24:13 +1100 Subject: [PATCH] Allow UTF-8 labels in label_replace This makes it consistent with label_join. Signed-off-by: Joshua Hesketh --- promql/functions.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/promql/functions.go b/promql/functions.go index 938eefdf00..c2f292c3a6 100644 --- a/promql/functions.go +++ b/promql/functions.go @@ -1612,7 +1612,7 @@ func (ev *evaluator) evalLabelReplace(ctx context.Context, args parser.Expressio if err != nil { panic(fmt.Errorf("invalid regular expression in label_replace(): %s", regexStr)) } - if !model.LabelNameRE.MatchString(dst) { + if !model.LabelName(dst).IsValid() { panic(fmt.Errorf("invalid destination label name in label_replace(): %s", dst)) }