From e44335a7dfc2179704470d68be46897b9006e0af Mon Sep 17 00:00:00 2001 From: Owen Williams Date: Wed, 24 Jan 2024 16:33:40 -0500 Subject: [PATCH] notes for utf8 reads --- storage/remote/codec.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/storage/remote/codec.go b/storage/remote/codec.go index 9cf1ed8712..51911ab996 100644 --- a/storage/remote/codec.go +++ b/storage/remote/codec.go @@ -95,6 +95,7 @@ func EncodeReadResponse(resp *prompb.ReadResponse, w http.ResponseWriter) error // ToQuery builds a Query proto. func ToQuery(from, to int64, matchers []*labels.Matcher, hints *storage.SelectHints) (*prompb.Query, error) { + // XXXXX TODO maybe here is where we explode to union between possible names? ms, err := toLabelMatchers(matchers) if err != nil { return nil, err @@ -176,6 +177,8 @@ func ToQueryResult(ss storage.SeriesSet, sampleLimit int) (*prompb.QueryResult, // FromQueryResult unpacks and sorts a QueryResult proto. func FromQueryResult(sortSeries bool, res *prompb.QueryResult) storage.SeriesSet { + // XXXXXXXX TODO somewhere in here we need to collapse the metric names + // from exploded down to the single one we wanted. series := make([]storage.Series, 0, len(res.Timeseries)) for _, ts := range res.Timeseries { if err := validateLabelsAndMetricName(ts.Labels); err != nil {