mudhorn/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2025-02-02 08:31:11 -08:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

Avoid extra copying of label values

Browse source
This commit is contained in:
Patrick Oyarzun 2023-04-18 15:50:05 -05:00
parent cc9072ad64
commit e52ce3e361
No known key found for this signature in database
GPG key ID: 44B349E67EC0257A
1 changed files with 7 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
tsdb/querier.go
View file

@ -347,13 +347,15 @@ func labelValuesWithMatchers(r IndexReader, name string, matchers ...*labels.Mat
continue continue
} }
for i := len(allValues) - 1; i >= 0; i-- { // re-use the allValues slice to avoid allocations
if m.Matches(allValues[i]) { // this is safe because the iteration is always ahead of the append
continue filteredValues := allValues[:0]
for _, v := range allValues {
if m.Matches(v) {
filteredValues = append(filteredValues, v)
} }
allValues = append(allValues[:i], allValues[i+1:]...)
} }
allValues = filteredValues
} }
valuesPostings := make([]index.Postings, len(allValues)) valuesPostings := make([]index.Postings, len(allValues))