mudhorn/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2024-11-10 15:44:05 -08:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

Fix expunging of empty memory series (loop var pointerization bug)

Browse source
This commit is contained in:
Julius Volz 2013-06-26 18:00:47 +02:00
parent 1bd8ee15f3
commit e7f049c85b
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
storage/metric/memory.go
View file

@ -227,7 +227,7 @@ func (s *memorySeriesStorage) getOrCreateSeries(metric clientmodel.Metric, finge
} }
func (s *memorySeriesStorage) Flush(flushOlderThan time.Time, queue chan<- clientmodel.Samples) { func (s *memorySeriesStorage) Flush(flushOlderThan time.Time, queue chan<- clientmodel.Samples) {
emptySeries := clientmodel.Fingerprints{} emptySeries := []clientmodel.Fingerprint{}
s.RLock() s.RLock()
for fingerprint, stream := range s.fingerprintToSeries { for fingerprint, stream := range s.fingerprintToSeries {
@ -258,7 +258,7 @@ func (s *memorySeriesStorage) Flush(flushOlderThan time.Time, queue chan<- clien
stream.values = toKeep stream.values = toKeep
if len(toKeep) == 0 { if len(toKeep) == 0 {
emptySeries = append(emptySeries, &fingerprint) emptySeries = append(emptySeries, fingerprint)
} }
stream.Unlock() stream.Unlock()
} }
@ -266,8 +266,8 @@ func (s *memorySeriesStorage) Flush(flushOlderThan time.Time, queue chan<- clien
s.Lock() s.Lock()
for _, fingerprint := range emptySeries { for _, fingerprint := range emptySeries {
if s.fingerprintToSeries[*fingerprint].empty() { if s.fingerprintToSeries[fingerprint].empty() {
s.dropSeries(fingerprint) s.dropSeries(&fingerprint)
} }
} }
s.Unlock() s.Unlock()