feat: multiple changes

- implement changes from pair programming session
- use newParse.val()
- advance parser p if ct is found

Signed-off-by: Manik Rana <manikrana54@gmail.com>

model/textparse/openmetricsparse.go

@@ -21,7 +21,6 @@ import (
 	"fmt"
 	"io"
 	"math"
-	"strconv"
 	"strings"
 	"unicode/utf8"
 
@@ -224,51 +223,55 @@ func (p *OpenMetricsParser) Exemplar(e *exemplar.Exemplar) bool {
 // CreatedTimestamp returns nil as it's not implemented yet.
 // TODO(bwplotka): https://github.com/prometheus/prometheus/issues/12980
 func (p *OpenMetricsParser) CreatedTimestamp() *int64 {
+	var lbs labels.Labels
+	p.Metric(&lbs)
+	lbs = lbs.DropMetricName()
+
 	newParser := deepCopyParser(p)
+loop:
+	for {
 		switch t, _ := newParser.Next(); t {
 		case EntrySeries:
 			// continue instead of return nil until we get new series/labels. can happen for histograms, summaries
-			for { 
 			// Check _created suffix
-				var lbs labels.Labels
+			var newLbs labels.Labels
-				newParser.Metric(&lbs)
+			newParser.Metric(&newLbs)
-				name := lbs.Get(model.MetricNameLabel)
+			name := newLbs.Get(model.MetricNameLabel)
-				if name[len(name)-8:] != "_created" { 
+			if !strings.HasSuffix(name, "_created") {
-					return nil
+				continue
 			}
 
+			// TODO: potentially broken? Missing type?
 			if newParser.mName != p.mName {
 				return nil
 			}
 
 			// edge case: if guage_created of unknown type -> skip parsing
-
+			newLbs = newLbs.DropMetricName()
-				// Check if labelsets are the same
+			if !labels.Equal(lbs, newLbs) {
+				return nil
+			}
 
 			// TODO: for histograms
 			// if t, _ := newParser.Next(); t != EntrySeries {
 			// 	return nil
 			// }
 			
-				// return CT value
-				ctBytes := newParser.l.b[newParser.offsets[len(newParser.offsets)-1]+1:newParser.l.start]
-				ct, err := strconv.ParseInt(yoloString(ctBytes), 10, 64)
-				if err != nil {
-					return nil
-				}
-
 			// guage_created is a metric
+
+			ct := int64(newParser.val)
+			p.Next()
 			return &ct
-			}
 		default:
-			// If not series, we don't care.
+			break loop
+		}
 	}
 	return nil
- }
+}
 
- // We need this because we want offsets of the original parser unchanged when 
+// We need this because we want offsets of the original parser unchanged when
- // we're working with a new parser in CreatedTimeStamp()
+// we're working with a new parser in CreatedTimeStamp()
- func deepCopyParser(p *OpenMetricsParser) OpenMetricsParser {
+func deepCopyParser(p *OpenMetricsParser) OpenMetricsParser {
 	newB := make([]byte, len(p.l.b))
 	copy(newB, p.l.b)
 
@@ -289,27 +292,27 @@ func (p *OpenMetricsParser) CreatedTimestamp() *int64 {
 	newEOffsets := p.eOffsets
 	newExemplar := p.exemplar
 	newParser := OpenMetricsParser{
-		l       :newLexer,
+		l:       newLexer,
-		builder :p.builder,
+		builder: p.builder,
-		series  :newSeries,
+		series:  newSeries,
-		text    :newText,
+		text:    newText,
-		mtype   :p.mtype,
+		mtype:   p.mtype,
-		mName   :p.mName,
+		mName:   p.mName,
-		val     :p.val,
+		val:     p.val,
-		ts      :p.ts,
+		ts:      p.ts,
-		hasTS   :p.hasTS,
+		hasTS:   p.hasTS,
-		start   :p.start,
+		start:   p.start,
 
-		offsets :newOffsets,
+		offsets: newOffsets,
 
-		eOffsets      :newEOffsets,
+		eOffsets:      newEOffsets,
-		exemplar      :newExemplar,
+		exemplar:      newExemplar,
-		exemplarVal   :p.exemplarVal,
+		exemplarVal:   p.exemplarVal,
-		exemplarTs    :p.exemplarTs,
+		exemplarTs:    p.exemplarTs,
-		hasExemplarTs :p.hasExemplarTs,
+		hasExemplarTs: p.hasExemplarTs,
 	}
 	return newParser
- }
+}
 
 // nextToken returns the next token from the openMetricsLexer.
 func (p *OpenMetricsParser) nextToken() token {