mudhorn/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2024-09-19 23:37:31 -07:00
Code Issues Actions 7 Packages Projects Releases Wiki Activity

Interface simplifications: GetRangeValues

Browse source 
From pointers to copies.
This commit is contained in:
Matt T. Proud 2013-02-13 21:11:23 -08:00
parent 14788cf4f3
commit f03091b139
4 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
rules/ast/persistence_adapter.go
View file

@ -74,7 +74,7 @@ func (p *PersistenceAdapter) GetBoundaryValues(labels model.LabelSet, interval *
sampleSets := []*model.SampleSet{} sampleSets := []*model.SampleSet{}
for _, metric := range metrics { for _, metric := range metrics {
// TODO: change to GetBoundaryValues() once it has the right return type. // TODO: change to GetBoundaryValues() once it has the right return type.
sampleSet, err := p.persistence.GetRangeValues(metric, interval, p.stalenessPolicy) sampleSet, err := p.persistence.GetRangeValues(*metric, *interval, *p.stalenessPolicy)
if err != nil { if err != nil {
return nil, err return nil, err
} }
@ -97,7 +97,7 @@ func (p *PersistenceAdapter) GetRangeValues(labels model.LabelSet, interval *mod
sampleSets := []*model.SampleSet{} sampleSets := []*model.SampleSet{}
for _, metric := range metrics { for _, metric := range metrics {
sampleSet, err := p.persistence.GetRangeValues(metric, interval, p.stalenessPolicy) sampleSet, err := p.persistence.GetRangeValues(*metric, *interval, *p.stalenessPolicy)
if err != nil { if err != nil {
return nil, err return nil, err
} }

2
storage/metric/interface.go
View file

@ -44,7 +44,7 @@ type MetricPersistence interface {
GetValueAtTime(model.Metric, time.Time, StalenessPolicy) (*model.Sample, error) GetValueAtTime(model.Metric, time.Time, StalenessPolicy) (*model.Sample, error)
GetBoundaryValues(model.Metric, model.Interval, StalenessPolicy) (*model.Sample, *model.Sample, error) GetBoundaryValues(model.Metric, model.Interval, StalenessPolicy) (*model.Sample, *model.Sample, error)
GetRangeValues(*model.Metric, *model.Interval, *StalenessPolicy) (*model.SampleSet, error) GetRangeValues(model.Metric, model.Interval, StalenessPolicy) (*model.SampleSet, error)
GetAllMetricNames() ([]string, error) GetAllMetricNames() ([]string, error)

2
storage/metric/leveldb/reading.go
View file

@ -553,7 +553,7 @@ func (l *LevelDBMetricPersistence) GetValueAtTime(m model.Metric, t time.Time, s
return return
} }
func (l *LevelDBMetricPersistence) GetRangeValues(m *model.Metric, i *model.Interval, s *metric.StalenessPolicy) (v *model.SampleSet, err error) { func (l *LevelDBMetricPersistence) GetRangeValues(m model.Metric, i model.Interval, s metric.StalenessPolicy) (v *model.SampleSet, err error) {
begin := time.Now() begin := time.Now()
defer func() { defer func() {

2
storage/metric/leveldb/rule_integration_test.go
View file

@ -1652,7 +1652,7 @@ var testGetRangeValues = func(t test.Tester) {
DeltaAllowance: input.staleness, DeltaAllowance: input.staleness,
} }
values, err := persistence.GetRangeValues(&m, &i, &p) values, err := persistence.GetRangeValues(m, i, p)
if err != nil { if err != nil {
t.Errorf("%d.%d(%s). Could not query for value: %q\n", i, j, behavior.name, err) t.Errorf("%d.%d(%s). Could not query for value: %q\n", i, j, behavior.name, err)
} }