mudhorn/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2024-11-14 09:34:05 -08:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity

minor fixes

Browse source 
Fix lint errors.
No need to pre-allocate exemplars.

Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
This commit is contained in:
György Krajcsovits 2024-10-09 11:45:31 +02:00
parent fbbf10baad
commit f3c8ed2947
1 changed files with 4 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
model/textparse/nhcbparse.go
View file

@ -28,7 +28,7 @@ import (
"github.com/prometheus/prometheus/util/convertnhcb" "github.com/prometheus/prometheus/util/convertnhcb"
) )
var labelsMismatchError = errors.New("labels mismatch") var errLabelsMismatch = errors.New("labels mismatch")
type NHCBParser struct { type NHCBParser struct {
// The parser we're wrapping. // The parser we're wrapping.
@ -82,7 +82,6 @@ func NewNHCBParser(p Parser, keepClassicHistograms bool) Parser {
parser: p, parser: p,
keepClassicHistograms: keepClassicHistograms, keepClassicHistograms: keepClassicHistograms,
tempNHCB: convertnhcb.NewTempHistogram(), tempNHCB: convertnhcb.NewTempHistogram(),
tempExemplars: make([]exemplar.Exemplar, 0, 1),
} }
} }
@ -212,7 +211,7 @@ func (p *NHCBParser) compareLabels() bool {
} else { } else {
p.lastBaseHistLabels = labels.EmptyLabels() p.lastBaseHistLabels = labels.EmptyLabels()
} }
return labelsMismatchError return errLabelsMismatch
} }
case l.Value != p.lastBaseHistLabels.Get(l.Name): case l.Value != p.lastBaseHistLabels.Get(l.Name):
// Different label value. // Different label value.
@ -221,11 +220,11 @@ func (p *NHCBParser) compareLabels() bool {
} else { } else {
p.lastBaseHistLabels = labels.EmptyLabels() p.lastBaseHistLabels = labels.EmptyLabels()
} }
return labelsMismatchError return errLabelsMismatch
} }
return nil return nil
}) })
return err == labelsMismatchError return errors.Is(err, errLabelsMismatch)
} }
// Save the label set of the classic histogram without suffix and bucket `le` label. // Save the label set of the classic histogram without suffix and bucket `le` label.