mudhorn/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2025-01-12 06:17:27 -08:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

tsdb/wal: fix flaky TestReaderFuzz* tests

Browse source 
It seems sometimes you can get error like:

                Error:          Not equal:
                                expected: []byte(nil)
                                actual  : []byte{}

                                Diff:
                                --- Expected
                                +++ Actual
                                @@ -1,2 +1,3 @@
                                -([]uint8) <nil>
                                +([]uint8) {
                                +}

This commit does what bytes.Equal does to silence those differences. I'm
not sure if this is a correct solution or just covering up the actual bug.

Closes #9574

Signed-off-by: Mateusz Gozdek <mgozdekof@gmail.com>
This commit is contained in:
Mateusz Gozdek 2021-10-23 08:55:48 +02:00 committed by Julien Pivotto
parent 4c56a193c5
commit f4650c27e7
1 changed files with 13 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
tsdb/wal/reader_test.go
View file

@ -334,7 +334,13 @@ func TestReaderFuzz(t *testing.T) {
reader := fn(sr) reader := fn(sr)
for expected := range input { for expected := range input {
require.True(t, reader.Next(), "expected record: %v", reader.Err()) require.True(t, reader.Next(), "expected record: %v", reader.Err())
require.Equal(t, expected, reader.Record(), "read wrong record") r := reader.Record()
// Expected value may come as nil or empty slice, so it requires special comparison.
if len(expected) == 0 {
require.Len(t, r, 0)
} else {
require.Equal(t, expected, r, "read wrong record")
}
} }
require.False(t, reader.Next(), "unexpected record") require.False(t, reader.Next(), "unexpected record")
}) })
@ -380,7 +386,12 @@ func TestReaderFuzz_Live(t *testing.T) {
rec := r.Record() rec := r.Record()
expected, ok := <-input expected, ok := <-input
require.True(t, ok, "unexpected record") require.True(t, ok, "unexpected record")
require.Equal(t, expected, rec, "record does not match expected") // Expected value may come as nil or empty slice, so it requires special comparison.
if len(expected) == 0 {
require.Len(t, rec, 0)
} else {
require.Equal(t, expected, rec, "record does not match expected")
}
} }
require.Equal(t, io.EOF, r.Err(), "expected EOF, got: %v", r.Err()) require.Equal(t, io.EOF, r.Err(), "expected EOF, got: %v", r.Err())
return true return true