mudhorn/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2024-12-25 21:54:10 -08:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

fix missing db.Close() in web_test.go in order to avoid goroutine leak (#10035)

Browse source 
Signed-off-by: Shihao Xia <charlesxsh@hotmail.com>
This commit is contained in:
Shihao Xia 2021-12-20 07:07:53 -05:00 committed by GitHub
parent 27343277fa
commit f5c3ea1bf2
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
web/web_test.go
View file

@ -116,7 +116,9 @@ func TestReadyAndHealthy(t *testing.T) {
db, err := tsdb.Open(dbDir, nil, nil, nil, nil) db, err := tsdb.Open(dbDir, nil, nil, nil, nil)
require.NoError(t, err) require.NoError(t, err)
t.Cleanup(func() {
require.NoError(t, db.Close())
})
port := fmt.Sprintf(":%d", testutil.RandomUnprivilegedPort(t)) port := fmt.Sprintf(":%d", testutil.RandomUnprivilegedPort(t))
opts := &Options{ opts := &Options{
@ -237,6 +239,9 @@ func TestRoutePrefix(t *testing.T) {
db, err := tsdb.Open(dbDir, nil, nil, nil, nil) db, err := tsdb.Open(dbDir, nil, nil, nil, nil)
require.NoError(t, err) require.NoError(t, err)
t.Cleanup(func() {
require.NoError(t, db.Close())
})
port := fmt.Sprintf(":%d", testutil.RandomUnprivilegedPort(t)) port := fmt.Sprintf(":%d", testutil.RandomUnprivilegedPort(t))
@ -404,7 +409,9 @@ func TestShutdownWithStaleConnection(t *testing.T) {
db, err := tsdb.Open(dbDir, nil, nil, nil, nil) db, err := tsdb.Open(dbDir, nil, nil, nil, nil)
require.NoError(t, err) require.NoError(t, err)
t.Cleanup(func() {
require.NoError(t, db.Close())
})
timeout := 10 * time.Second timeout := 10 * time.Second
port := fmt.Sprintf(":%d", testutil.RandomUnprivilegedPort(t)) port := fmt.Sprintf(":%d", testutil.RandomUnprivilegedPort(t))