mudhorn/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2025-03-05 20:59:13 -08:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

Add PR template

Browse source 
Signed-off-by: Richard Hartmann <richih@richih.org>
This commit is contained in:
Richard Hartmann 2021-06-23 12:21:19 +02:00
parent 4a5aef0495
commit f76dd36d17
1 changed files with 9 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
.github/PULL_REQUEST_TEMPLATE.md vendored
View file

@ -1,15 +1,17 @@
<!-- <!--
Don't forget! Don't forget!
- Sign your commits and our DCO: https://docs.github.com/en/github/authenticating-to-github/managing-commit-signature-verification/signing-commits
- If the PR adds or changes a behaviour or fixes a bug of an exported API it would need a unit/e2e test. - If the PR adds or changes a behaviour or fixes a bug of an exported API it would need a unit/e2e test.
- Where possible use only exported APIs for tests to simplify the review and make it as close as possible to an actual library usage. - Where possible use only exported APIs for tests to simplify the review and make it as close as possible to an actual library usage.
- No tests are needed for internal implementation changes. - No tests are needed for internal implementation changes.
- Performance improvements would need a benchmark test to prove it. - Performance improvements would need a benchmark test to prove it.
- All exposed objects should have a comment. - All exposed objects should have a comment.
- All comments should start with a capital letter and end with a full stop. - All comments should start with a capital letter and end with a full stop.
--> -->