mudhorn/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2025-03-05 20:59:13 -08:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

Correct error check for child walk

Browse source 
This was checking another error not childErr -- which would skip child errors and cause issues. I haven't seen this in practice but found while debugging another issue.
This commit is contained in:
Thomas Jackson 2023-03-30 08:11:48 -07:00 committed by Rishabh Kumar
parent a95115a6da
commit f77a0e5aba
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
promql/parser/ast.go
View file

@ -357,7 +357,7 @@ func Walk(ctx context.Context, v Visitor, s *EvalStmt, node Node, path []Node, n
wg.Add(1) wg.Add(1)
go func(i int, e Node) { go func(i int, e Node) {
defer wg.Done() defer wg.Done()
if childNode, childErr := Walk(ctx, v, s, e, append([]Node{}, path...), nr); err != nil { if childNode, childErr := Walk(ctx, v, s, e, append([]Node{}, path...), nr); childErr != nil {
errs[i] = childErr errs[i] = childErr
} else { } else {
newChildren[i] = childNode newChildren[i] = childNode