Fix AllPostings added twice (#13893)

* handle all postings added twice

---------

Signed-off-by: Ben Ye <benye@amazon.com>

tsdb/querier.go

@@ -193,6 +193,11 @@ func selectChunkSeriesSet(ctx context.Context, sortSeries bool, hints *storage.S
 // PostingsForMatchers assembles a single postings iterator against the index reader
 // based on the given matchers. The resulting postings are not ordered by series.
 func PostingsForMatchers(ctx context.Context, ix IndexReader, ms ...*labels.Matcher) (index.Postings, error) {
+	if len(ms) == 1 && ms[0].Name == "" && ms[0].Value == "" {
+		k, v := index.AllPostingsKey()
+		return ix.Postings(ctx, k, v)
+	}
+
 	var its, notIts []index.Postings
 	// See which label must be non-empty.
 	// Optimization for case like {l=~".", l!="1"}.
@@ -247,13 +252,10 @@ func PostingsForMatchers(ctx context.Context, ix IndexReader, ms ...*labels.Matc
 			return nil, ctx.Err()
 		}
 		switch {
-		case m.Name == "" && m.Value == "": // Special-case for AllPostings, used in tests at least.
+		case m.Name == "" && m.Value == "":
-			k, v := index.AllPostingsKey()
+			// We already handled the case at the top of the function,
-			allPostings, err := ix.Postings(ctx, k, v)
+			// and it is unexpected to get all postings again here.
-			if err != nil {
+			return nil, errors.New("unexpected all postings")
-				return nil, err
-			}
-			its = append(its, allPostings)
 		case m.Type == labels.MatchRegexp && m.Value == ".*":
 			// .* regexp matches any string: do nothing.
 		case m.Type == labels.MatchNotRegexp && m.Value == ".*":