mudhorn/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2025-03-05 20:59:13 -08:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

Use buffer pool for head appenders

Browse source
This commit is contained in:
Fabian Reinartz 2017-01-12 20:00:36 +01:00
parent a317f252b9
commit fde69dab49
2 changed files with 18 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
cmd/tsdb/main.go
View file

@ -150,7 +150,7 @@ func (b *writeBenchmark) ingestScrapes(metrics []model.Metric, scrapeCount int)
lbls = append(lbls, lset) lbls = append(lbls, lset)
} }
for i := 0; i < scrapeCount; i += 25 { for i := 0; i < scrapeCount; i += 50 {
lbls := lbls lbls := lbls
for len(lbls) > 0 { for len(lbls) > 0 {
l := 1000 l := 1000
@ -162,7 +162,7 @@ func (b *writeBenchmark) ingestScrapes(metrics []model.Metric, scrapeCount int)
wg.Add(1) wg.Add(1)
go func() { go func() {
n, err := b.ingestScrapesShard(batch, 25, int64(30000*i)) n, err := b.ingestScrapesShard(batch, 50, int64(30000*i))
if err != nil { if err != nil {
// exitWithError(err) // exitWithError(err)
fmt.Println(" err", err) fmt.Println(" err", err)

17
head.go
View file

@ -107,7 +107,21 @@ func (h *headBlock) Stats() BlockStats {
func (h *headBlock) Appender() Appender { func (h *headBlock) Appender() Appender {
h.mtx.RLock() h.mtx.RLock()
return &headAppender{headBlock: h} return &headAppender{headBlock: h, samples: getHeadAppendBuffer()}
}
var headPool = sync.Pool{}
func getHeadAppendBuffer() []hashedSample {
b := headPool.Get()
if b == nil {
return make([]hashedSample, 0, 512)
}
return b.([]hashedSample)
}
func putHeadAppendBuffer(b []hashedSample) {
headPool.Put(b[:0])
} }
type headAppender struct { type headAppender struct {
@ -213,6 +227,7 @@ func (a *headAppender) createSeries() {
} }
func (a *headAppender) Commit() error { func (a *headAppender) Commit() error {
defer putHeadAppendBuffer(a.samples)
defer a.mtx.RUnlock() defer a.mtx.RUnlock()
// Write all new series and samples to the WAL and add it to the // Write all new series and samples to the WAL and add it to the