mudhorn/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2025-03-05 20:59:13 -08:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

update the discover tests

Browse source 
the discovery test is now only testing update and get groups.
It doesn't do an e2e test but just a unit test of setting and receiving
target groups
This commit is contained in:
Krasi Georgiev 2018-01-27 12:03:06 +00:00
parent 46693444de
commit fe926e7829
1 changed files with 11 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
discovery/manager_test.go
View file

@ -29,8 +29,8 @@ import (
"gopkg.in/yaml.v2" "gopkg.in/yaml.v2"
) )
// TestDiscoveryManagerSyncCalls checks that the target updates are received in the expected order. // TestTargetUpdatesOrder checks that the target updates are received in the expected order.
func TestDiscoveryManagerSyncCalls(t *testing.T) { func TestTargetUpdatesOrder(t *testing.T) {
// The order by which the updates are send is detirmened by the interval passed to the mock discovery adapter // The order by which the updates are send is detirmened by the interval passed to the mock discovery adapter
// Final targets array is ordered alphabetically by the name of the discoverer. // Final targets array is ordered alphabetically by the name of the discoverer.
@ -656,15 +656,14 @@ func TestDiscoveryManagerSyncCalls(t *testing.T) {
ctx, cancel := context.WithCancel(context.Background()) ctx, cancel := context.WithCancel(context.Background())
defer cancel() defer cancel()
discoveryManager := NewManager(nil) discoveryManager := NewManager(nil)
go discoveryManager.Run(ctx)
var totalUpdatesCount int var totalUpdatesCount int
for tpName, update := range testCase.updates {
provider := newMockDiscoveryProvider(update)
discoveryManager.startProvider(ctx, poolKey{setName: strconv.Itoa(testIndex), provider: tpName}, provider)
if len(update) > 0 { provUpdates := make(chan []*targetgroup.Group)
totalUpdatesCount = totalUpdatesCount + len(update) for _, up := range testCase.updates {
go newMockDiscoveryProvider(up).Run(ctx, provUpdates)
if len(up) > 0 {
totalUpdatesCount = totalUpdatesCount + len(up)
} }
} }
@ -674,9 +673,10 @@ func TestDiscoveryManagerSyncCalls(t *testing.T) {
case <-time.After(10 * time.Second): case <-time.After(10 * time.Second):
t.Errorf("%v. %q: no update arrived within the timeout limit", x, testCase.title) t.Errorf("%v. %q: no update arrived within the timeout limit", x, testCase.title)
break Loop break Loop
case tsetMap := <-discoveryManager.SyncCh(): case tgs := <-provUpdates:
for _, received := range tsetMap { discoveryManager.updateGroup(poolKey{setName: strconv.Itoa(testIndex), provider: testCase.title}, tgs)
// Need to sort by the Groups source as the Discovery manager doesn't guarantee the order. for _, received := range discoveryManager.allGroups() {
// Need to sort by the Groups source as the received order is not guaranteed.
sort.Sort(byGroupSource(received)) sort.Sort(byGroupSource(received))
if !reflect.DeepEqual(received, testCase.expectedTargets[x]) { if !reflect.DeepEqual(received, testCase.expectedTargets[x]) {
var receivedFormated string var receivedFormated string