mudhorn/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2024-11-14 09:34:05 -08:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity
7652 commits 248 branches 440 tags 656 MiB
Commit graph

5 commits

Author SHA1 Message Date
Bartlomiej Plotka cfba92a133 Addressed comments. 
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
 2020-02-17 18:03:57 +00:00
Bartlomiej Plotka fb79f515fc Fixed second bug. 
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
 2020-02-17 18:03:57 +00:00
Bartlomiej Plotka aadffd1360 Finally found a fix for the bug I was chasing for 2h... 
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
 2020-02-17 18:03:57 +00:00
Bartlomiej Plotka 34426766d8 Unify Iterator interfaces. All point to storage now. 
This is part of https://github.com/prometheus/prometheus/pull/5882 that can be done to simplify things.
All todos I added will be fixed in follow up PRs.

* querier.Querier, querier.Appender, querier.SeriesSet, and querier.Series interfaces merged
with storage interface.go. All imports that.
* querier.SeriesIterator replaced by chunkenc.Iterator
* Added chunkenc.Iterator.Seek method and tests for xor implementation (?)
* Since we properly handle SelectParams for Select methods I adjusted min max
based on that. This should help in terms of performance for queries with functions like offset.
* added Seek to deletedIterator and test.
* storage/tsdb was removed as it was only a unnecessary glue with incompatible structs.

No logic was changed, only different source of abstractions, so no need for benchmarks.

Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
 2020-02-17 18:03:54 +00:00
Chris Marchbanks 0685eb5395
Refactor testutil.NewStorage into a new package 
This avoids a circular dependency between the testutil and storage
packages.

Signed-off-by: Chris Marchbanks <csmarchbanks@gmail.com>
 2019-08-08 19:43:04 -06:00
Renamed from util/testutil/storage.go (Browse further)