mudhorn/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2024-11-09 23:24:05 -08:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity
9125 commits 245 branches 436 tags 650 MiB
Commit graph

99 commits

Author SHA1 Message Date
George Robinson 049b4f4f13
Support customization of template options in TemplateExpander (#9290) 
Signed-off-by: George Robinson <george.robinson@grafana.com>
 2021-09-13 17:19:08 +05:30
Levi Harrison 8c29046ab2
Remove unneeded state modifications 
Signed-off-by: Levi Harrison <git@leviharrison.dev>
 2021-08-20 16:42:31 -04:00
Levi Harrison b5f6f8fb36 Switched to go-kit/log 
Signed-off-by: Levi Harrison <git@leviharrison.dev>
 2021-06-11 12:28:36 -04:00
Levi Harrison 17ea8d006a
Added external URL access 
Signed-off-by: Levi Harrison <git@leviharrison.dev>
 2021-05-30 23:35:26 -04:00
Julien Pivotto 4e5b1722b3
Move away from testutil, refactor imports (#8087) 
Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
 2020-10-22 11:00:08 +02:00
johncming a69a8b931f
rules: fix bug for unknown alert state. (#7599) 
Signed-off-by: johncming <johncming@yahoo.com>
 2020-07-17 08:39:15 +01:00
Brian Brazil 5368066b58
Give a bit more slack for alertmanager send failures. (#7228) 
Fixes #5277

Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>
 2020-05-09 05:37:46 +01:00
Tobias Guggenmos 20b1f596f6 Fix build errors in rest of prometheus 
Signed-off-by: Tobias Guggenmos <tguggenm@redhat.com>
 2020-02-17 16:09:23 +01:00
Julien Pivotto 0e912faf4f
rules: Cleanup unused function alert.Duration (#6734) 
The function HoldDuration and Duration did the exact same thing.

Let's only keep HoldDuration() as Duration() is more confusing.

Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
 2020-02-01 07:31:37 +00:00
Julien Pivotto 2d7c8069d0 Check that rules don't contain metrics with the same labelset (#6469) 
Closes #5529

Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
 2019-12-18 12:29:35 +00:00
AllenZMC 5c2c9a03e9 fix word 'consequentally' to 'consequently' (#5827) 
Signed-off-by: czm <zhongming.chang@daocloud.io>
 2019-08-03 14:56:58 +01:00
Bjoern Rabenstein 38d518c0fe Rework #5009 after comments 
Signed-off-by: Bjoern Rabenstein <bjoern@rabenste.in>
 2019-04-17 01:40:10 +02:00
Sylvain Rabot 335a34486e Add external labels to template expansion 
This affects the expansion of templates in alert labels and
annotations and console templates.

Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr>
 2019-04-17 01:40:10 +02:00
Tariq Ibrahim 8fdfa8abea refine error handling in prometheus (#5388) 
i) Uses the more idiomatic Wrap and Wrapf methods for creating nested errors.
ii) Fixes some incorrect usages of fmt.Errorf where the error messages don't have any formatting directives.
iii) Does away with the use of fmt package for errors in favour of pkg/errors

Signed-off-by: tariqibrahim <tariq181290@gmail.com>
 2019-03-26 00:01:12 +01:00
Simon Pasquier f678e27eb6
*: use latest release of staticcheck (#5057) 
* *: use latest release of staticcheck

It also fixes a couple of things in the code flagged by the additional
checks.

Signed-off-by: Simon Pasquier <spasquie@redhat.com>

* Use official release of staticcheck

Also run 'go list' before staticcheck to avoid failures when downloading packages.

Signed-off-by: Simon Pasquier <spasquie@redhat.com>
 2019-01-04 14:47:38 +01:00
AixesHunter fb8479a677 Variable 'labels' collides with imported package name (#5012) 
Signed-off-by: aixeshunter <aixeshunter@gmail.com>
 2018-12-19 09:44:03 +00:00
Ben Kochie c6399296dc
Fix spelling/typos (#4921) 
* Fix spelling/typos

Fix spelling/typos reported by codespell/misspell.
* UK -> US spelling changes.

Signed-off-by: Ben Kochie <superq@gmail.com>
 2018-11-27 17:44:29 +01:00
Will Hegedus 193ebe7e34 Updates to /targets and /rules (scrape duration, last evaluation time) (#4722) 
* Add evaluationTimestamp (Last Evaluation) column to display on /rules
Signed-off-by: Will Hegedus <wbhegedus@liberty.edu>

* Add lastScrapeDuration ("Scrape Duration") to display on /targets
Signed-off-by: Will Hegedus <wbhegedus@liberty.edu>

* Updates based on Julius' feedback

Signed-off-by: Will Hegedus <wbhegedus@liberty.edu>

* Update to set timestamp to when eval started (after eval completes)

Signed-off-by: Will Hegedus <wbhegedus@liberty.edu>

* Update /rules to display time since last evaluation

Signed-off-by: Will Hegedus <wbhegedus@liberty.edu>

* Re-order Last Eval/Eval Time to be consistent with targets page

Signed-off-by: Will Hegedus <wbhegedus@liberty.edu>
 2018-10-12 18:26:59 +02:00
Ganesh Vernekar 05726c5ea2 Test template expansion while loading groups (#4537) 
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
 2018-09-13 13:55:58 +01:00
Chris Marchbanks 63ed9d1b70 Send EndsAt along with alerts (#4550) 
Signed-off-by: Chris Marchbanks <csmarchbanks@gmail.com>
 2018-08-28 16:05:00 +01:00
Chris Marchbanks 87f1dad16d throttle resends of alerts to 1 minute by default (#4538) 
Signed-off-by: Chris Marchbanks <csmarchbanks@gmail.com>
 2018-08-27 17:41:42 +01:00
Goutham Veeramachaneni f3b7c22827 rules: add comment about lock taking (#4525) 
Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
 2018-08-21 21:30:08 +02:00
Chris Marchbanks 11155c7028 Existing alert labels will update based on templates (#4500) 
Signed-off-by: Chris Marchbanks <csmarchbanks@gmail.com>
 2018-08-15 08:52:08 +01:00
Fabian Reinartz b7e2f407de rules: Fix double-locking of mutex 
Signed-off-by: Fabian Reinartz <freinartz@google.com>
 2018-08-07 07:33:39 -04:00
Benji Visser 8bb6e0dd6e Show rule evaluation errors on rules page (#4457) 
* adding information about the health and errors for Rules

adding Health() and LastError() to the Rule interface. This will allow
us to easily surface information about rules.

Signed-off-by: noqcks <benny@noqcks.io>

* updating rules.html with fields for Rule errors and health state

Signed-off-by: noqcks <benny@noqcks.io>

* fix code comment grammar & access Rule health/error info using a mutex

Signed-off-by: noqcks <benny@noqcks.io>

* s/Errors/Error/ in rules.html to remain consistent with targets.html

Signed-off-by: noqcks <benny@noqcks.io>

* adding periods to code comments in reporting/alerting

Signed-off-by: noqcks <benny@noqcks.io>

* putting health/error below mutex in struct field

Signed-off-by: noqcks <benny@noqcks.io>
 2018-08-07 00:33:45 +02:00
Julius Volz 2b8fc062a8
rules: HTML-escape rule YAML marshal errors (#4464) 
This was pointed out by `gosec`.

Signed-off-by: Julius Volz <julius.volz@gmail.com>
 2018-08-05 14:01:51 +02:00
Ganesh Vernekar f1db699dff Persist alert 'for' state across restarts (#4061) 
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
 2018-08-02 11:18:24 +01:00
Max Leonard Inden 71fafad099
api/v1: Coninue work exposing rules and alerts 
Signed-off-by: Max Leonard Inden <IndenML@gmail.com>
 2018-07-30 15:31:51 +02:00
mg03 31f8ca0dfb
api v1 alerts/rules json endpoint 
Signed-off-by: mg03 <mgeng03@gmail.com>
 2018-07-30 15:29:44 +02:00
Julius Volz 9e3171f6e3 rules: Minor naming/comment cleanups (#4328) 
Signed-off-by: Julius Volz <julius.volz@gmail.com>
 2018-07-18 04:54:33 +01:00
ferhat elmas ec8e4d8a7c all: remove unnecessary type conversions (#3992) 
excep promql due to not to create conflict with #3966.
 2018-03-21 09:25:22 +00:00
Simon Pasquier 81c0ab69e0 Don't reset FiredAt for inactive alerts 
Otherwise AlertManager receives resolved alerts where StartsAt is zero which
fails the validation.
 2018-01-22 17:17:33 +01:00
Fabian Reinartz 62461379b7 rules: decouple notifier packages 
The dependency on the notifier packages caused a transitive dependency
on discovery and with that all client libraries our service discovery
uses.
 2017-11-27 16:38:14 +01:00
Fabian Reinartz 2d0e3746ac rules: remove dependency on promql.Engine 2017-11-24 07:57:54 +01:00
Goutham Veeramachaneni a880c86375
Fix unexported method on exported interface. 
Also move to model.Duration

Signed-off-by: Goutham Veeramachaneni <cs14btech11014@iith.ac.in>
 2017-11-23 19:13:57 +05:30
conorbroderick 55aaece116 Add rule evaluation time 2017-11-22 15:22:02 +00:00
Julius Volz 099df0c5f0 Migrate "golang.org/x/net/context" -> "context" (#3333) 
In some places, where ctxhttp or gRPC are concerned, we still need to use the
old contexts.
 2017-10-24 21:21:42 -07:00
Fabian Reinartz 2d0b8e8b94 Merge branch 'master' into dev-2.0 2017-10-05 13:09:18 +02:00
beorn7 c2e9a151ab Make all rule links link to the "Console" tab rather than "Graph" 
Clicking on a rule, either the name or the expression, opens the rule
result (or the corresponding expression, repsectively) in the
expression browser. This should by default happen in the console tab,
as, more often than not, displaying it in the graph tab runs into a
timeout.
 2017-09-21 18:28:00 +02:00
Fabian Reinartz d21f149745 *: migrate to go-kit/log 2017-09-08 22:01:51 +05:30
Goutham Veeramachaneni e1fc9dc78d Move /rules to new format (#2901) 
Fixes #2891

Signed-off-by: Goutham Veeramachaneni <goutham@boomerangcommerce.com>
 2017-07-08 11:38:02 +02:00
Goutham Veeramachaneni 507790a357
Rework logging to use explicitly passed logger 
Mostly cleaned up the global logger use. Still some uses in discovery
package.

Signed-off-by: Goutham Veeramachaneni <cs14btech11014@iith.ac.in>
 2017-06-16 15:52:44 +05:30
Brian Brazil dcea3e4773 Don't append a 0 when alert is no longer pending/firing 
With staleness we no longer need this behaviour.
 2017-05-24 13:52:45 +01:00
Fabian Reinartz 06c2b76cd4 Merge branch 'master' into uptsdb 2017-05-16 16:48:37 +02:00
Julius Volz ac203ef0ee Add externalURL template function (#2716) 
This allows users to e.g. add links back to the generating Prometheus
right in their alert templates.
 2017-05-13 15:47:04 +02:00
Julius Volz fe11c5933a Fix mutation of active alert elements by notifier (#2656) 
This caused the external label application in the notifier to bleed back
into the rule manager's active alerting elements.
 2017-04-26 10:29:42 -05:00
Fabian Reinartz e94b0899ee rules: fix tests, remove model types 2016-12-29 17:31:14 +01:00
Fabian Reinartz 5817cb5bde *: migrate from model.* to promql.* types 2016-12-25 00:37:46 +01:00
Fabian Reinartz e68a3cf21f rules: update annotations on each iteration 2016-11-22 15:43:07 +01:00
Jonathan Lange 2a2da40223 Make rule evaluation publicly available 
Means that a third-party can parse rules and run them with their own
execution model.
 2016-11-18 16:12:50 +00:00