* web: replace deprecated InstrumentHandler()
This change replaces the deprecated InstrumentHandler function by the
equivalent functions from the promhttp package.
The following metrics are removed:
* http_request_duration_microseconds (Summary).
* http_request_size_bytes (Summary).
* http_requests_total (Counter).
And the following metrics are added instead:
* prometheus_http_request_duration_seconds (Histogram).
* prometheus_http_response_size_bytes (Histogram).
* promhttp_metric_handler_requests_in_flight (Gauge).
* promhttp_metric_handler_requests_total (Counter).
* Update github.com/prometheus/common/route package
* web: refactor using the new prometheus/common/route package
This doesn't perform any actual updates. (While that is something that
we should consider eventually, it leads down a rabbit hole and would
be too risky just before the 2.0.0 release.)
This is really just a clean-up. In particular:
- The following packages are not really used and thus removed:
- github.com/blang/semver
- github.com/coreos/go-oidc/http
- github.com/coreos/go-oidc/jose
- github.com/coreos/go-oidc/key
- github.com/coreos/go-oidc/oauth2
- github.com/coreos/go-oidc/oidc
- github.com/coreos/pkg/health
- github.com/coreos/pkg/httputil
- github.com/coreos/pkg/timeutil
- github.com/gophercloud/gophercloud/openstack/compute/v2/extensions
- github.com/pborman/uuid
- For unclear reasons, the checksum for the following packages were
wrong. The only change in this commit is to adjust the checksum in
vendor.json. No changes of source code involved.
- github.com/cespare/xxhash
- github.com/dgryski/go-bits
- github.com/golang/snappy
- Various packages from the github.com/gogo/protobuf repository are
used throughout the code. They are vendored from various sources
(different sub-vendoring of cockroachdb/cockroach and
k8s.io/client-go) and revisions. I made them all consistently
referring to the current version of the github.com/gogo/protobuf
repository. This _is_ a change of code, but a necessary one to clean
up the inconsistencies.
- For the github.com/influxdata/influxdb/... packages, the license
files were missing. Also, the revision time was wrong, again for
unknown reason.
This tries to avoid any real updates (as that would lead down a rabbit
hole, although I think we should check what dependencies need an
update one day) but at least tries to remove unused packages.
The usage of govalidator is redundant with the call to url.Parse for
url validation. Removing it has the following benefits:
- The explicit error message is displayed instead of just a generic
valid/invalid message
- Slightly smaller code with one fewer external dependency
- Speed improvement by removing duplicate call to url.Parse (inside
govalidator.IsURL()
- Resolves issue #2717
The only potential drawback of removing govalidator is that certain
URLs will be considered valid which were previously invalid. For example:
- URLs with hostnames that start and/or end with an underscore (http://_example.com_)
- URLs with hostnames that contain some special characters (http://foo&*bar.org)
These are valid URIs according to RFC 3986 and valid domain names per RFC 2181,
however they are not valid hostnames per RFC 952.
