dependabot[bot]
e5415f8ecd
chore(deps): bump sanitize-html from 2.13.1 to 2.14.0 in /web/ui ( #15739 )
...
Bumps [sanitize-html](https://github.com/apostrophecms/sanitize-html ) from 2.13.1 to 2.14.0.
- [Changelog](https://github.com/apostrophecms/sanitize-html/blob/main/CHANGELOG.md )
- [Commits](https://github.com/apostrophecms/sanitize-html/compare/2.13.1...2.14.0 )
---
updated-dependencies:
- dependency-name: sanitize-html
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-01-13 21:54:09 +01:00
leonnicolas
fccd78d3cd
Update storage keys
...
Signed-off-by: leonnicolas <leonloechner@gmx.de>
2025-01-13 21:46:45 +01:00
dependabot[bot]
287e56058b
chore(deps): bump google.golang.org/grpc from 1.69.0 to 1.69.4 ( #15811 )
...
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go ) from 1.69.0 to 1.69.4.
- [Release notes](https://github.com/grpc/grpc-go/releases )
- [Commits](https://github.com/grpc/grpc-go/compare/v1.69.0...v1.69.4 )
---
updated-dependencies:
- dependency-name: google.golang.org/grpc
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-01-13 20:23:36 +01:00
dependabot[bot]
16f3639521
chore(deps-dev): bump @rollup/plugin-node-resolve in /web/ui ( #15740 )
...
Bumps [@rollup/plugin-node-resolve](https://github.com/rollup/plugins/tree/HEAD/packages/node-resolve ) from 15.3.0 to 16.0.0.
- [Changelog](https://github.com/rollup/plugins/blob/master/packages/node-resolve/CHANGELOG.md )
- [Commits](https://github.com/rollup/plugins/commits/commonjs-v16.0.0/packages/node-resolve )
---
updated-dependencies:
- dependency-name: "@rollup/plugin-node-resolve"
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-01-13 19:59:32 +01:00
dependabot[bot]
c5ef7153e0
chore(deps): bump @tanstack/react-query in /web/ui ( #15737 )
...
Bumps [@tanstack/react-query](https://github.com/TanStack/query/tree/HEAD/packages/react-query ) from 5.62.7 to 5.62.11.
- [Release notes](https://github.com/TanStack/query/releases )
- [Commits](https://github.com/TanStack/query/commits/v5.62.11/packages/react-query )
---
updated-dependencies:
- dependency-name: "@tanstack/react-query"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-01-13 19:58:55 +01:00
dependabot[bot]
75d9c328d7
chore(deps): bump react-router-dom from 7.0.2 to 7.1.1 in /web/ui ( #15743 )
...
Bumps [react-router-dom](https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom ) from 7.0.2 to 7.1.1.
- [Release notes](https://github.com/remix-run/react-router/releases )
- [Changelog](https://github.com/remix-run/react-router/blob/main/packages/react-router-dom/CHANGELOG.md )
- [Commits](https://github.com/remix-run/react-router/commits/react-router-dom@7.1.1/packages/react-router-dom )
---
updated-dependencies:
- dependency-name: react-router-dom
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-01-13 19:58:17 +01:00
dependabot[bot]
938bb65518
chore(deps): bump @mantine/code-highlight in /web/ui ( #15749 )
...
Bumps [@mantine/code-highlight](https://github.com/mantinedev/mantine/tree/HEAD/packages/@mantine/code-highlight ) from 7.15.0 to 7.15.2.
- [Release notes](https://github.com/mantinedev/mantine/releases )
- [Changelog](https://github.com/mantinedev/mantine/blob/master/CHANGELOG.md )
- [Commits](https://github.com/mantinedev/mantine/commits/7.15.2/packages/@mantine/code-highlight )
---
updated-dependencies:
- dependency-name: "@mantine/code-highlight"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-01-13 19:57:14 +01:00
dependabot[bot]
e24375f1b3
chore(deps): bump @codemirror/language in /web/ui/react-app ( #15754 )
...
Bumps [@codemirror/language](https://github.com/codemirror/language ) from 6.10.6 to 6.10.8.
- [Changelog](https://github.com/codemirror/language/blob/main/CHANGELOG.md )
- [Commits](https://github.com/codemirror/language/compare/6.10.6...6.10.8 )
---
updated-dependencies:
- dependency-name: "@codemirror/language"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-01-13 19:56:42 +01:00
dependabot[bot]
23fe8bc1a3
chore(deps-dev): bump globals from 15.13.0 to 15.14.0 in /web/ui ( #15751 )
...
Bumps [globals](https://github.com/sindresorhus/globals ) from 15.13.0 to 15.14.0.
- [Release notes](https://github.com/sindresorhus/globals/releases )
- [Commits](https://github.com/sindresorhus/globals/compare/v15.13.0...v15.14.0 )
---
updated-dependencies:
- dependency-name: globals
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-01-13 19:56:14 +01:00
dependabot[bot]
a59f23f55b
chore(deps): bump @uiw/react-codemirror from 4.23.6 to 4.23.7 in /web/ui ( #15752 )
...
Bumps [@uiw/react-codemirror](https://github.com/uiwjs/react-codemirror ) from 4.23.6 to 4.23.7.
- [Release notes](https://github.com/uiwjs/react-codemirror/releases )
- [Commits](https://github.com/uiwjs/react-codemirror/compare/v4.23.6...v4.23.7 )
---
updated-dependencies:
- dependency-name: "@uiw/react-codemirror"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-01-13 19:55:49 +01:00
dependabot[bot]
2c2a1ac66d
chore(deps-dev): bump @eslint/js from 9.16.0 to 9.17.0 in /web/ui ( #15753 )
...
Bumps [@eslint/js](https://github.com/eslint/eslint/tree/HEAD/packages/js ) from 9.16.0 to 9.17.0.
- [Release notes](https://github.com/eslint/eslint/releases )
- [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md )
- [Commits](https://github.com/eslint/eslint/commits/v9.17.0/packages/js )
---
updated-dependencies:
- dependency-name: "@eslint/js"
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-01-13 19:55:02 +01:00
dependabot[bot]
16420e859f
chore(deps): bump @codemirror/view in /web/ui/react-app ( #15761 )
...
Bumps [@codemirror/view](https://github.com/codemirror/view ) from 6.35.3 to 6.36.1.
- [Changelog](https://github.com/codemirror/view/blob/main/CHANGELOG.md )
- [Commits](https://github.com/codemirror/view/compare/6.35.3...6.36.1 )
---
updated-dependencies:
- dependency-name: "@codemirror/view"
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-01-13 19:54:17 +01:00
dependabot[bot]
0bc95c388f
chore(deps): bump google.golang.org/api from 0.213.0 to 0.216.0 ( #15812 )
...
Bumps [google.golang.org/api](https://github.com/googleapis/google-api-go-client ) from 0.213.0 to 0.216.0.
- [Release notes](https://github.com/googleapis/google-api-go-client/releases )
- [Changelog](https://github.com/googleapis/google-api-go-client/blob/main/CHANGES.md )
- [Commits](https://github.com/googleapis/google-api-go-client/compare/v0.213.0...v0.216.0 )
---
updated-dependencies:
- dependency-name: google.golang.org/api
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-01-13 19:46:39 +01:00
dependabot[bot]
f5976c0afb
chore(deps): bump sass from 1.82.0 to 1.83.0 in /web/ui/react-app ( #15762 )
...
Bumps [sass](https://github.com/sass/dart-sass ) from 1.82.0 to 1.83.0.
- [Release notes](https://github.com/sass/dart-sass/releases )
- [Changelog](https://github.com/sass/dart-sass/blob/main/CHANGELOG.md )
- [Commits](https://github.com/sass/dart-sass/compare/1.82.0...1.83.0 )
---
updated-dependencies:
- dependency-name: sass
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-01-13 19:14:43 +01:00
dependabot[bot]
cb0dc8bc55
chore(deps): bump bufbuild/buf-setup-action from 1.47.2 to 1.48.0 ( #15756 )
...
Bumps [bufbuild/buf-setup-action](https://github.com/bufbuild/buf-setup-action ) from 1.47.2 to 1.48.0.
- [Release notes](https://github.com/bufbuild/buf-setup-action/releases )
- [Commits](9672cee018...1115d0acd3
)
---
updated-dependencies:
- dependency-name: bufbuild/buf-setup-action
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-01-13 19:13:47 +01:00
dependabot[bot]
ebb3c4e35f
chore(deps): bump actions/upload-artifact from 4.4.3 to 4.5.0 ( #15757 )
...
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact ) from 4.4.3 to 4.5.0.
- [Release notes](https://github.com/actions/upload-artifact/releases )
- [Commits](b4b15b8c7c...6f51ac03b9
)
---
updated-dependencies:
- dependency-name: actions/upload-artifact
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-01-13 19:13:29 +01:00
dependabot[bot]
2a5cd8179d
chore(deps): bump github/codeql-action from 3.27.7 to 3.28.0 ( #15759 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.27.7 to 3.28.0.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](babb554ede...48ab28a6f5
)
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-01-13 19:13:12 +01:00
dependabot[bot]
3351e79a50
chore(deps-dev): bump @types/node in /web/ui/react-app ( #15768 )
...
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node ) from 22.10.2 to 22.10.3.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases )
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node )
---
updated-dependencies:
- dependency-name: "@types/node"
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-01-13 19:12:25 +01:00
dependabot[bot]
337c739418
chore(deps): bump github.com/linode/linodego from 1.43.0 to 1.44.0 ( #15770 )
...
Bumps [github.com/linode/linodego](https://github.com/linode/linodego ) from 1.43.0 to 1.44.0.
- [Release notes](https://github.com/linode/linodego/releases )
- [Commits](https://github.com/linode/linodego/compare/v1.43.0...v1.44.0 )
---
updated-dependencies:
- dependency-name: github.com/linode/linodego
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-01-13 19:11:53 +01:00
dependabot[bot]
042cea1e18
chore(deps): bump google.golang.org/protobuf from 1.36.0 to 1.36.1 ( #15767 )
...
Bumps google.golang.org/protobuf from 1.36.0 to 1.36.1.
---
updated-dependencies:
- dependency-name: google.golang.org/protobuf
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-01-13 19:08:03 +01:00
dependabot[bot]
1542e73b66
chore(deps): bump github.com/prometheus/sigv4 from 0.1.0 to 0.1.1 ( #15764 )
...
Bumps [github.com/prometheus/sigv4](https://github.com/prometheus/sigv4 ) from 0.1.0 to 0.1.1.
- [Release notes](https://github.com/prometheus/sigv4/releases )
- [Changelog](https://github.com/prometheus/sigv4/blob/main/RELEASE.md )
- [Commits](https://github.com/prometheus/sigv4/compare/v0.1.0...v0.1.1 )
---
updated-dependencies:
- dependency-name: github.com/prometheus/sigv4
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-01-13 19:07:29 +01:00
dependabot[bot]
7e27fd7417
chore(deps-dev): bump vite from 6.0.3 to 6.0.7 in /web/ui ( #15781 )
...
Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite ) from 6.0.3 to 6.0.7.
- [Release notes](https://github.com/vitejs/vite/releases )
- [Changelog](https://github.com/vitejs/vite/blob/main/packages/vite/CHANGELOG.md )
- [Commits](https://github.com/vitejs/vite/commits/v6.0.7/packages/vite )
---
updated-dependencies:
- dependency-name: vite
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-01-13 19:06:49 +01:00
Julius Volz
1e7e5b63cf
Merge pull request #15810 from prometheus/ui-merge-alerts-page-settings
...
Merge two accidental "Alerts page settings" sections into one
2025-01-13 18:23:05 +01:00
leonnicolas
36520fd8b2
Remove settings from setting menu
...
Signed-off-by: leonnicolas <leonloechner@gmx.de>
2025-01-13 17:56:11 +01:00
Julius Volz
60b71108e5
Merge two accidental "Alerts page settings" sections into one
...
Signed-off-by: Julius Volz <julius.volz@gmail.com>
2025-01-13 16:25:26 +01:00
leonnicolas
b3531a12f3
Make "show empty pools" setting persistent
...
Just like for showing empty groups on the Alerts page, also make the
setting for showing empty pools on the Targets page persistent.
Signed-off-by: leonnicolas <leonloechner@gmx.de>
2025-01-13 12:59:26 +01:00
Julius Volz
0d7db907a9
Merge pull request #15785 from crystalstall/main
...
CI / Go tests (push) Waiting to run
CI / More Go tests (push) Waiting to run
CI / Go tests with previous Go version (push) Waiting to run
CI / UI tests (push) Waiting to run
CI / Go tests on Windows (push) Waiting to run
CI / Mixins tests (push) Waiting to run
CI / Build Prometheus for common architectures (0) (push) Waiting to run
CI / Build Prometheus for common architectures (1) (push) Waiting to run
CI / Build Prometheus for common architectures (2) (push) Waiting to run
CI / Build Prometheus for all architectures (0) (push) Waiting to run
CI / Build Prometheus for all architectures (1) (push) Waiting to run
CI / Build Prometheus for all architectures (10) (push) Waiting to run
CI / Build Prometheus for all architectures (11) (push) Waiting to run
CI / Build Prometheus for all architectures (2) (push) Waiting to run
CI / Build Prometheus for all architectures (3) (push) Waiting to run
CI / Build Prometheus for all architectures (4) (push) Waiting to run
CI / Build Prometheus for all architectures (5) (push) Waiting to run
CI / Build Prometheus for all architectures (6) (push) Waiting to run
CI / Build Prometheus for all architectures (7) (push) Waiting to run
CI / Build Prometheus for all architectures (8) (push) Waiting to run
CI / Build Prometheus for all architectures (9) (push) Waiting to run
CI / Report status of build Prometheus for all architectures (push) Blocked by required conditions
CI / Check generated parser (push) Waiting to run
CI / golangci-lint (push) Waiting to run
CI / fuzzing (push) Waiting to run
CI / codeql (push) Waiting to run
CI / Publish main branch artifacts (push) Blocked by required conditions
CI / Publish release artefacts (push) Blocked by required conditions
CI / Publish UI on npm Registry (push) Blocked by required conditions
Scorecards supply-chain security / Scorecards analysis (push) Waiting to run
refactor: using slices.Contains to simplify the code
2025-01-13 10:31:41 +01:00
leonnicolas
6ccd9add1e
Make "hide empty rules persistent"
...
It can be a bit annoying to always press "hide empty rules". This commit
uses the session storage of the browser to make it persistent.
Signed-off-by: leonnicolas <leonloechner@gmx.de>
2025-01-10 23:32:05 +01:00
Owen Williams
47563d942e
parser: fix misleading error message in grouping processing
...
Signed-off-by: Owen Williams <owen.williams@grafana.com>
2025-01-10 15:23:33 -05:00
crystalstall
616914abe2
Signed-off-by: crystalstall <crystalruby@qq.com>
...
refactor: using slices.Contains to simplify the code
Signed-off-by: crystalstall <crystalruby@qq.com>
2025-01-11 00:41:51 +08:00
Julien Duchesne
0a19f1268e
Rule Concurrency: Simpler loop for sequential (default) executions ( #15801 )
CI / Go tests (push) Has been cancelled
CI / More Go tests (push) Has been cancelled
CI / Go tests with previous Go version (push) Has been cancelled
CI / UI tests (push) Has been cancelled
CI / Go tests on Windows (push) Has been cancelled
CI / Mixins tests (push) Has been cancelled
CI / Build Prometheus for common architectures (0) (push) Has been cancelled
CI / Build Prometheus for common architectures (1) (push) Has been cancelled
CI / Build Prometheus for common architectures (2) (push) Has been cancelled
CI / Build Prometheus for all architectures (0) (push) Has been cancelled
CI / Build Prometheus for all architectures (1) (push) Has been cancelled
CI / Build Prometheus for all architectures (10) (push) Has been cancelled
CI / Build Prometheus for all architectures (11) (push) Has been cancelled
CI / Build Prometheus for all architectures (2) (push) Has been cancelled
CI / Build Prometheus for all architectures (3) (push) Has been cancelled
CI / Build Prometheus for all architectures (4) (push) Has been cancelled
CI / Build Prometheus for all architectures (5) (push) Has been cancelled
CI / Build Prometheus for all architectures (6) (push) Has been cancelled
CI / Build Prometheus for all architectures (7) (push) Has been cancelled
CI / Build Prometheus for all architectures (8) (push) Has been cancelled
CI / Build Prometheus for all architectures (9) (push) Has been cancelled
CI / Check generated parser (push) Has been cancelled
CI / golangci-lint (push) Has been cancelled
CI / fuzzing (push) Has been cancelled
CI / codeql (push) Has been cancelled
Scorecards supply-chain security / Scorecards analysis (push) Has been cancelled
CI / Report status of build Prometheus for all architectures (push) Has been cancelled
CI / Publish main branch artifacts (push) Has been cancelled
CI / Publish release artefacts (push) Has been cancelled
CI / Publish UI on npm Registry (push) Has been cancelled
2025-01-09 23:14:21 +00:00
Lukasz Mierzwa
e3728122b2
Update comments for methods that require a lock
...
Signed-off-by: Lukasz Mierzwa <l.mierzwa@gmail.com>
2025-01-09 17:20:10 +00:00
Lukasz Mierzwa
a1740cd2e7
Remove unnecessary locks
...
Compact() is an uppercase function that deals with locks on its own, so we shouldn't have a lock around it.
Signed-off-by: Lukasz Mierzwa <lukasz@cloudflare.com>
2025-01-09 17:06:05 +00:00
Łukasz Mierzwa
d106b3beb7
Wrap db.blocks read in a read lock
...
We don't hold db.mtx lock when trying to read db.blocks here so we need a read lock around this loop.
Signed-off-by: Łukasz Mierzwa <l.mierzwa@gmail.com>
2025-01-09 17:06:05 +00:00
Łukasz Mierzwa
92788d313a
Remove TestTombstoneCleanRetentionLimitsRace
...
This test ensures that running db.reloadBlocks() and db.CleanTombstones() at the same time doesn't race.
The problem is that CleanTombstones() is a public method while reloadBlocks() is internal.
CleanTombstones() sets db.cmtx lock while reloadBlocks() is not protected by any locks at all, it expects the public method through which it was called to do it.
So having a race between these two is not unexpected and we shouldn't really be testing this.
db.cmtx ensures that no other function can be modifying the list of open blocks and so the scenario tested here cannot happen.
If it would happen it would be only because some other method doesn't aquire db.ctmx lock, something this test cannot detect.
Signed-off-by: Łukasz Mierzwa <l.mierzwa@gmail.com>
2025-01-09 17:06:03 +00:00
Łukasz Mierzwa
b880cea613
Fix locks in db.reloadBlocks()
...
This partially reverts ae3d392aa9
.
ae3d392aa9
added a call to db.mtx.Lock() that lasts for the entire duration of db.reloadBlocks(),
previous db.mtx would be locked only during critical part of db.reloadBlocks().
The motivation was to protect against races:
9e0351e161 (r555699794)
The 'reloads' being mentioned are (I think) reloadBlocks() calls, rather than db.reload() or other methods.
TestTombstoneCleanRetentionLimitsRace was added to catch this but I wasn't able to ever get any error out of it, even after disabling all calls to db.mtx in reloadBlocks() and CleanTombstones().
To make things more complicated CleanupTombstones() itself calls reloadBlocks(), so it seems that the real issue is that we might have concurrent calls to reloadBlocks().
The problem with this change is that db.reloadBlocks() can take a very long time, that's because it might need to load very large blocks from disk, which is slow.
While db.mtx is locked a large chunk of the db is locked, including queries, since db.mtx read lock is needed for db.Querier() call.
One of the issues this manifests itself as is a gap in all metrics and blocked queries just after a large block compaction happens.
When compaction merges multiple day-or-more blocks into a week-or-more block it create a single very big block.
After that block is written it needs to be loaded and that seems to be taking many seconds (30-45), during which mtx is held and everything is blocked.
Turns out that there is another lock that is more fine grained and aimed at this specific use case:
// cmtx ensures that compactions and deletions don't run simultaneously.
cmtx sync.Mutex
All calls to reloadBlocks() are wrapped inside cmtx lock. The only exception is db.reload() which this change fixes.
We can't add cmtx lock inside reloadBlocks() itself because it's called by a number of functions, some of which are already holding cmtx.
Looking at the code I think it is sufficient to hold cmtx and skip a reloadBlocks() wide mtx call.
Signed-off-by: Łukasz Mierzwa <l.mierzwa@gmail.com>
2025-01-09 17:05:39 +00:00
Arve Knudsen
f030894c2c
Fix issues raised by staticcheck ( #15722 )
...
CI / Go tests (push) Waiting to run
CI / More Go tests (push) Waiting to run
CI / Go tests with previous Go version (push) Waiting to run
CI / UI tests (push) Waiting to run
CI / Go tests on Windows (push) Waiting to run
CI / Mixins tests (push) Waiting to run
CI / Build Prometheus for common architectures (0) (push) Waiting to run
CI / Build Prometheus for common architectures (1) (push) Waiting to run
CI / Build Prometheus for common architectures (2) (push) Waiting to run
CI / Build Prometheus for all architectures (0) (push) Waiting to run
CI / Build Prometheus for all architectures (1) (push) Waiting to run
CI / Build Prometheus for all architectures (10) (push) Waiting to run
CI / Build Prometheus for all architectures (11) (push) Waiting to run
CI / Build Prometheus for all architectures (2) (push) Waiting to run
CI / Build Prometheus for all architectures (3) (push) Waiting to run
CI / Build Prometheus for all architectures (4) (push) Waiting to run
CI / Build Prometheus for all architectures (5) (push) Waiting to run
CI / Build Prometheus for all architectures (6) (push) Waiting to run
CI / Build Prometheus for all architectures (7) (push) Waiting to run
CI / Build Prometheus for all architectures (8) (push) Waiting to run
CI / Build Prometheus for all architectures (9) (push) Waiting to run
CI / Report status of build Prometheus for all architectures (push) Blocked by required conditions
CI / Check generated parser (push) Waiting to run
CI / golangci-lint (push) Waiting to run
CI / fuzzing (push) Waiting to run
CI / codeql (push) Waiting to run
CI / Publish main branch artifacts (push) Blocked by required conditions
CI / Publish release artefacts (push) Blocked by required conditions
CI / Publish UI on npm Registry (push) Blocked by required conditions
Scorecards supply-chain security / Scorecards analysis (push) Waiting to run
Fix issues raised by staticcheck
We are not enabling staticcheck explicitly, though, because it has too many false positives.
---------
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
2025-01-09 17:51:26 +01:00
Vandit Singh
6339989e25
web/api: Add a limit parameter to /query and /query_range ( #15552 )
...
add limit param to query and rangeQuery
---------
Signed-off-by: Vandit Singh <vanditsinghkv@gmail.com>
Signed-off-by: Vandit Singh <107131545+Vandit1604@users.noreply.github.com>
Co-authored-by: Björn Rabenstein <github@rabenste.in>
2025-01-09 17:27:39 +01:00
Neeraj Gartia
b3e30d52ce
[BUGFIX] PromQL: Fix <aggr_over_time>
functions with histograms ( #15711 )
...
fix aggr_over_time with histograms
Signed-off-by: Neeraj Gartia <neerajgartia211002@gmail.com>
---------
Signed-off-by: Neeraj Gartia <neerajgartia211002@gmail.com>
2025-01-09 16:38:42 +01:00
Matthias Loibl
d173c0b61c
Merge pull request #15334 from janhorstmann/feature/update-monitoring-mixin-dashboard
...
Update mixin dashboard
2025-01-09 14:54:05 +00:00
Fiona Liao
9d6f88cb73
Add additional tests for operators over incompatible nhcb ( #15787 )
...
CI / Go tests (push) Waiting to run
CI / More Go tests (push) Waiting to run
CI / Go tests with previous Go version (push) Waiting to run
CI / UI tests (push) Waiting to run
CI / Go tests on Windows (push) Waiting to run
CI / Mixins tests (push) Waiting to run
CI / Build Prometheus for common architectures (0) (push) Waiting to run
CI / Build Prometheus for common architectures (1) (push) Waiting to run
CI / Build Prometheus for common architectures (2) (push) Waiting to run
CI / Build Prometheus for all architectures (0) (push) Waiting to run
CI / Build Prometheus for all architectures (1) (push) Waiting to run
CI / Build Prometheus for all architectures (10) (push) Waiting to run
CI / Build Prometheus for all architectures (11) (push) Waiting to run
CI / Build Prometheus for all architectures (2) (push) Waiting to run
CI / Build Prometheus for all architectures (3) (push) Waiting to run
CI / Build Prometheus for all architectures (4) (push) Waiting to run
CI / Build Prometheus for all architectures (5) (push) Waiting to run
CI / Build Prometheus for all architectures (6) (push) Waiting to run
CI / Build Prometheus for all architectures (7) (push) Waiting to run
CI / Build Prometheus for all architectures (8) (push) Waiting to run
CI / Build Prometheus for all architectures (9) (push) Waiting to run
CI / Report status of build Prometheus for all architectures (push) Blocked by required conditions
CI / Check generated parser (push) Waiting to run
CI / golangci-lint (push) Waiting to run
CI / fuzzing (push) Waiting to run
CI / codeql (push) Waiting to run
CI / Publish main branch artifacts (push) Blocked by required conditions
CI / Publish release artefacts (push) Blocked by required conditions
CI / Publish UI on npm Registry (push) Blocked by required conditions
Scorecards supply-chain security / Scorecards analysis (push) Waiting to run
* Add additional tests for operators over incompatible nhcb
Signed-off-by: Fiona Liao <fiona.liao@grafana.com>
2025-01-09 10:29:57 +01:00
Julien Duchesne
a768a3b95e
Rule Concurrency: Test safe abort of rule evaluations ( #15797 )
...
CI / Go tests (push) Waiting to run
CI / More Go tests (push) Waiting to run
CI / Go tests with previous Go version (push) Waiting to run
CI / UI tests (push) Waiting to run
CI / Go tests on Windows (push) Waiting to run
CI / Mixins tests (push) Waiting to run
CI / Build Prometheus for common architectures (0) (push) Waiting to run
CI / Build Prometheus for common architectures (1) (push) Waiting to run
CI / Build Prometheus for common architectures (2) (push) Waiting to run
CI / Build Prometheus for all architectures (0) (push) Waiting to run
CI / Build Prometheus for all architectures (1) (push) Waiting to run
CI / Build Prometheus for all architectures (10) (push) Waiting to run
CI / Build Prometheus for all architectures (11) (push) Waiting to run
CI / Build Prometheus for all architectures (2) (push) Waiting to run
CI / Build Prometheus for all architectures (3) (push) Waiting to run
CI / Build Prometheus for all architectures (4) (push) Waiting to run
CI / Build Prometheus for all architectures (5) (push) Waiting to run
CI / Build Prometheus for all architectures (6) (push) Waiting to run
CI / Build Prometheus for all architectures (7) (push) Waiting to run
CI / Build Prometheus for all architectures (8) (push) Waiting to run
CI / Build Prometheus for all architectures (9) (push) Waiting to run
CI / Report status of build Prometheus for all architectures (push) Blocked by required conditions
CI / Check generated parser (push) Waiting to run
CI / golangci-lint (push) Waiting to run
CI / fuzzing (push) Waiting to run
CI / codeql (push) Waiting to run
CI / Publish main branch artifacts (push) Blocked by required conditions
CI / Publish release artefacts (push) Blocked by required conditions
CI / Publish UI on npm Registry (push) Blocked by required conditions
Scorecards supply-chain security / Scorecards analysis (push) Waiting to run
This test was added in the Grafana fork a while ago: https://github.com/grafana/mimir-prometheus/pull/714 and has been helpful to make sure we can safely terminate rule evaluations early
The new rule evaluation logic (done here: https://github.com/prometheus/prometheus/pull/15681 ) does not have the bug, but the test was useful to verify that
Signed-off-by: Julien Duchesne <julien.duchesne@grafana.com>
2025-01-08 16:32:48 +00:00
Björn Rabenstein
1ea9b72997
Merge pull request #15795 from prometheus/beorn7/promql
...
promqltest: let eval_ordered ignore annotations and improve documentation
2025-01-08 16:04:14 +01:00
beorn7
d9a80a91e3
docs: Document eval_warn and eval_info
...
This also improves the documentation in the following ways:
- Clarifies that `eval` requires no annotations.
- Clarifies that `eval_ordered` ignores annotations.
- Clarifies that `eval_ordered` does not work with matrix returns
(which could very well be created by instant queries).
- Clarifies that there are more `eval` commands than just `eval`.
- Improves wording for `eval_ordered`.
- Replaces `...` by the typographical correct `…`.
- Fixes a numerical error in an example.
Signed-off-by: beorn7 <beorn@grafana.com>
2025-01-08 13:57:13 +01:00
beorn7
7687661453
promqltest: make eval_ordered ignore annotations
...
Besides making eval_ordered ignore annotations, this does the following:
- Adds a test to verify that eval_ordered indeed ignores an info
annotations now, while eval complains about it, eval_info recognizes
it and, eval_warn flags the missing of the warn annotation.
- Refactors the annotation check into its own method.
- Moves closing of the query to the appropriate place where it wasn't
so far.
Signed-off-by: beorn7 <beorn@grafana.com>
2025-01-08 12:55:27 +01:00
Julius Volz
02501e097e
Merge pull request #15789 from prometheus/beorn7/doc2
...
CI / Go tests (push) Waiting to run
CI / More Go tests (push) Waiting to run
CI / Go tests with previous Go version (push) Waiting to run
CI / UI tests (push) Waiting to run
CI / Go tests on Windows (push) Waiting to run
CI / Mixins tests (push) Waiting to run
CI / Build Prometheus for common architectures (0) (push) Waiting to run
CI / Build Prometheus for common architectures (1) (push) Waiting to run
CI / Build Prometheus for common architectures (2) (push) Waiting to run
CI / Build Prometheus for all architectures (0) (push) Waiting to run
CI / Build Prometheus for all architectures (1) (push) Waiting to run
CI / Build Prometheus for all architectures (10) (push) Waiting to run
CI / Build Prometheus for all architectures (11) (push) Waiting to run
CI / Build Prometheus for all architectures (2) (push) Waiting to run
CI / Build Prometheus for all architectures (3) (push) Waiting to run
CI / Build Prometheus for all architectures (4) (push) Waiting to run
CI / Build Prometheus for all architectures (5) (push) Waiting to run
CI / Build Prometheus for all architectures (6) (push) Waiting to run
CI / Build Prometheus for all architectures (7) (push) Waiting to run
CI / Build Prometheus for all architectures (8) (push) Waiting to run
CI / Build Prometheus for all architectures (9) (push) Waiting to run
CI / Report status of build Prometheus for all architectures (push) Blocked by required conditions
CI / Check generated parser (push) Waiting to run
CI / golangci-lint (push) Waiting to run
CI / fuzzing (push) Waiting to run
CI / codeql (push) Waiting to run
CI / Publish main branch artifacts (push) Blocked by required conditions
CI / Publish release artefacts (push) Blocked by required conditions
CI / Publish UI on npm Registry (push) Blocked by required conditions
Scorecards supply-chain security / Scorecards analysis (push) Waiting to run
docs: fix spelling
2025-01-07 19:39:08 +01:00
Ben Ye
919a5b657e
Expose ListPostings Length via Len() method ( #15678 )
...
tsdb: expose remaining ListPostings Length
Signed-off-by: Ben Ye <benye@amazon.com>
---------
Signed-off-by: Ben Ye <benye@amazon.com>
2025-01-07 17:58:26 +01:00
beorn7
df55e536b8
docs: fix spelling
...
Signed-off-by: beorn7 <beorn@grafana.com>
2025-01-07 17:51:57 +01:00
Julius Volz
18bb8bf996
Merge pull request #15784 from sujalshah-bit/15394_server_name_and_time
...
api: Add two new fields Hostname and ServerTime.
2025-01-07 13:36:53 +01:00
sujal shah
73a3438c1b
api: Add two new fields Node and ServerTime.
...
This commit introduced two field in `/status` endpoint:
- The node currently serving the request.
- The current server time for debugging time drift issues.
fixes #15394 .
Signed-off-by: sujal shah <sujalshah28092004@gmail.com>
2025-01-07 16:05:50 +05:30