4 commits

Author	SHA1	Message	Date
Dan Milstein	ec064c96f6	Add field names to table-driven test fixtures	2016-08-30 07:57:39 -04:00
Dan Milstein	ac8788aca6	Convert to table-driven test and inline helper func	2016-08-30 07:57:39 -04:00
Dan Milstein	f50f656a66	Fix double-delta unmarshaling to respect actual min header size ... Turns out its valid to have an overall chunk which is smaller than the full doubleDeltaHeaderBytes size -- if it has a single sample, it doesn't fill the whole header. Updated unmarshalling check to respect this.	2016-08-30 07:57:39 -04:00
Dan Milstein	b815956341	Catch errors when unmarshalling delta/doubleDelta encoded chunks ... This is (hopefully) a fix for #1653 Specifically, this makes it so that if the length for the stored delta/doubleDelta is somehow corrupted to be too small, the attempt to unmarshal will return an error. The current (broken) behavior is to return a malformed chunk, which can then lead to a panic when there is an attempt to read header values. The referenced issue proposed creating chunks with a minimum length -- I instead opted to just error on the attempt to unmarshal, since I'm not clear on how it could be safe to proceed when the length is incorrect/unknown. The issue also talked about possibly "quarantining series", but I don't know the surrounding code well enough to understand how to make that happen.	2016-08-30 07:57:39 -04:00