1184 commits

Author	SHA1	Message	Date
Neeraj Gartia	9009724c5b	[BUGFIX] PromQL: Adds test for absent, absent_over_time and deriv func with histograms (#15667) ... Add test for `absent`, `absent_over_time` and `deriv` func with histograms Signed-off-by: Neeraj Gartia <neerajgartia211002@gmail.com> --------- Signed-off-by: Neeraj Gartia <neerajgartia211002@gmail.com>	2024-12-13 13:34:55 +01:00
Bartlomiej Plotka	791df4305e	Merge pull request #15668 from firetiger-inc/promqltest-with-storage ... promqltest: allow running tests with custom storage implementation	2024-12-13 10:20:46 +01:00
beorn7	ebfa1dd822	promql: Purge Holt-Winters from a doc comment ... `funcDoubleExponentialSmoothing` did not get its doc comment updated when we renamed it from the confusing `funcHoltWinters`. Signed-off-by: beorn7 <beorn@grafana.com>	2024-12-11 12:03:19 +01:00
Achille Roussel	b0e7de154e	promqltest: allow running tests with custom storage implementation ... Signed-off-by: Achille Roussel <achille.roussel@gmail.com>	2024-12-10 17:36:44 -08:00
Björn Rabenstein	3a4e7710a0	Merge pull request #15531 from prometheus/owilliams/promqltest ... promql: Fix various UTF-8 bugs related to quoting	2024-12-10 17:45:10 +01:00
Owen Williams	8d4bcd2c77	promql: Fix various UTF-8 bugs related to quoting ... Fixes UTF-8 aggregator label list items getting mutated with quote marks when String-ified. Fixes quoted metric names not supported in metric declarations. Fixes UTF-8 label names not being quoted when String-ified. Fixes https://github.com/prometheus/prometheus/issues/15470 Fixes https://github.com/prometheus/prometheus/issues/15528 Signed-off-by: Owen Williams <owen.williams@grafana.com> Co-authored-by: Bryan Boreham <bjboreham@gmail.com>	2024-12-04 14:18:59 -05:00
Neeraj Gartia	7fd3b13bd2	[TEST] PromQL: Adds tests with histograms for simple functions (#15488) ... adds tests with histograms for simple functions Signed-off-by: Neeraj Gartia <neerajgartia211002@gmail.com> --------- Signed-off-by: Neeraj Gartia <neerajgartia211002@gmail.com>	2024-12-04 13:11:05 +01:00
Björn Rabenstein	6a6630d2a7	Merge pull request #15527 from NeerajGartia21/promql/funcResets ... [BUGFIX] PromQL: Fix `resets` function for histograms	2024-12-03 22:43:07 +01:00
Neeraj Gartia	4aeed2c4b1	fix resets function for histograms ... Signed-off-by: Neeraj Gartia <neerajgartia211002@gmail.com>	2024-12-03 19:01:05 +05:30
George Krajcsovits	aceabbc81c	Merge pull request #14638 from roidelapluie/evalsubtest ... promqltest: run each eval command in a subtest	2024-12-03 12:41:37 +01:00
Björn Rabenstein	dfbfe8b5e8	Merge pull request #15479 from NeerajGartia21/promql/datewrapper ... [BUGFIX] PromQL: Ignore histograms in all time related functions	2024-11-29 00:26:52 +01:00
TJ Hoplock	aa8e067f13	Merge release-3.0 into main	2024-11-27 17:51:51 -05:00
Neeraj Gartia	0de340c1b4	ignore histogram in dateWrapper ... Signed-off-by: Neeraj Gartia <neerajgartia211002@gmail.com>	2024-11-28 01:57:04 +05:30
Neeraj Gartia	36e0897f0f	[BUGFIX] PromQL: Fix behaviour of changes() for mix of histograms and floats (#15469) ... PromQL: Fix behaviour of changes() for mix of histograms and floats --------- Signed-off-by: Neeraj Gartia <neerajgartia211002@gmail.com>	2024-11-27 21:05:08 +01:00
Björn Rabenstein	a7264eb0d4	Merge pull request #15475 from prometheus/beorn7/promql ... promql: Add NaN tests for avg and avg_over_time	2024-11-27 19:41:39 +01:00
Joshua Hesketh	8e3301eb44	Export quantile functions (#15190) ... Export quantile functions For use in Mimir's query engine, it would be helpful if these functions were exported. Co-authored-by: Björn Rabenstein <github@rabenste.in> Signed-off-by: Joshua Hesketh <josh@hesketh.net.au> --------- Signed-off-by: Joshua Hesketh <josh@nitrotech.org> Signed-off-by: Joshua Hesketh <josh@hesketh.net.au> Co-authored-by: Björn Rabenstein <github@rabenste.in>	2024-11-27 13:20:23 +01:00
beorn7	a44c449155	promql: Add NaN tests for avg and avg_over_time ... Signed-off-by: beorn7 <beorn@grafana.com>	2024-11-27 13:08:34 +01:00
Neeraj Gartia	38bb6ece25	[BUGFIX] PromQL: Fix behaviour of some aggregations with histograms (#15432) ... promql: fix some aggregations for histograms This PR fixes the behaviour of `topk`,`bottomk`, `limitk` and `limit_ratio` with histograms. The fixed behaviour are as follows: - For `topk` and `bottomk` histograms are ignored and add info annotations added. - For `limitk` and `limit_ratio` histograms are included in the results(if applicable). Signed-off-by: Neeraj Gartia <neerajgartia211002@gmail.com>	2024-11-26 19:12:36 +01:00
newtonne	88675710f9	Add support for utf8 names on /v1/label/:name/values endpoint ... Previously, the api was evaluating this regex to determine if the label name was valid or not: 14bac55a99/model/labels.go (L94) However, I believe that the `IsValid()` function is what ought to be used in the brave new utf8 era. **Before** ``` $ curl localhost:9090/api/v1/label/host.name/values {"status":"error","errorType":"bad_data","error":"invalid label name: \"host.name\""} ``` **After** ``` $ curl localhost:9090/api/v1/label/host.name/values {"status":"success","data":["localhost"]} ``` It's very likely that I'm missing something here or you were already planning to do this at some point but I just encountered this issue and figured I'd give it a go. Signed-off-by: Owen Williams <owen.williams@grafana.com>	2024-11-25 11:48:45 -05:00
György Krajcsovits	a48d05912d	nhcb: optimize, do not recalculate suffixes multiple times ... Reduce string manipulation by just cutting off the histogram suffixes from the series name label once. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>	2024-11-25 15:37:38 +01:00
Neeraj Gartia	abfc3145a2	apply DRY on clamp (#15441) ... Signed-off-by: Neeraj Gartia <neerajgartia211002@gmail.com>	2024-11-24 17:08:59 +01:00
TJ Hoplock	3e24e84172	fix!: stop unbounded memory usage from query log ... Resolves: #15433 When I converted prometheus to use slog in #14906, I update both the `QueryLogger` interface, as well as how the log calls to the `QueryLogger` were built up in `promql.Engine.exec()`. The backing logger for the `QueryLogger` in the engine is a `util/logging.JSONFileLogger`, and it's implementation of the `With()` method updates the logger the logger in place with the new keyvals added onto the underlying slog.Logger, which means they get inherited onto everything after. All subsequent calls to `With()`, even in later queries, would continue to then append on more and more keyvals for the various params and fields built up in the logger. In turn, this causes unbounded growth of the logger, leading to increased memory usage, and in at least one report was the likely cause of an OOM kill. More information can be found in the issue and the linked slack thread. This commit does a few things: - It was referenced in feedback in #14906 that it would've been better to not change the `QueryLogger` interface if possible, this PR proposes changes that bring it closer to alignment with the pre-3.0 `QueryLogger` interface contract - reverts `promql.Engine.exec()`'s usage of the query logger to the pattern of building up an array of args to pass at once to the end log call. Avoiding the repetitious calls to `.With()` are what resolve the issue with the logger growth/memory usage. - updates the scrape failure logger to use the update `QueryLogger` methods in the contract. - updates tests accordingly - cleans up unused methods Builds and passes tests successfully. Tested locally and confirmed I could no longer reproduce the issue/it resolved the issue. Signed-off-by: TJ Hoplock <t.hoplock@gmail.com>	2024-11-23 14:20:37 -05:00
beorn7	4b573e0521	promql: Fix subqueries to be really left-open ... Previously, we managed to get rid of the sample on the left bound later, so the problem didn't show up in the framework tests. But the subqueries were still evaluation with the sample on the left bound, taking space and showing up if returning the subquery result directly (without further processing through PromQL like in all the framework tests). Signed-off-by: beorn7 <beorn@grafana.com>	2024-11-21 14:28:05 +01:00
Björn Rabenstein	125a90899c	promqltest: Complete the tests for info annotations (#15429) ... promqltest: Complete the tests for info annotations So far, we did not test for the _absence_ of an info annotation (because many tests triggered info annotations, which we haven't taken into account so far). The test for info annotations was also missed for range queries. This completes the tests for info annotations (and refactors the many `if` statements into a somewhat more compact `switch` statement). It fixes most tests to not emit an info annotation anymore. Or it changes the `eval` to `eval_info` where we actually want to test for the info annotation. It also fixes a few spelling errors in comments. --------- Signed-off-by: beorn7 <beorn@grafana.com> Signed-off-by: Björn Rabenstein <github@rabenste.in> Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com>	2024-11-21 14:20:38 +01:00
Arve Knudsen	89bbb885e5	Upgrade to golangci-lint v1.62.0 (#15424) ... Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>	2024-11-20 17:22:20 +01:00
Björn Rabenstein	e8003cb347	Merge pull request #15417 from huochexizhan/main ... chore: fix some function names in comment	2024-11-20 14:36:47 +01:00
Neeraj Gartia	a6fb16fcb4	PromQL: Convert more native histogram tests to promql-test framework (#15419) ... This converts `TestNativeHistogram_SubOperator` to the promql testing framework. It also removes `TestNativeHistogram_Sum_Count_Add_AvgOperator`, which got converted earlier. Signed-off-by: Neeraj Gartia <neerajgartia211002@gmail.com>	2024-11-20 11:41:36 +01:00
Björn Rabenstein	4ef1170868	Merge pull request #15422 from NeerajGartia21/promql-corrections ... [BUGFIX] PromQL: Fix `count_values` for histograms	2024-11-20 11:27:32 +01:00
George Krajcsovits	5cd9855999	tests(promql/testdata): add regression test for and-on (#15425) ... * tests(promql/testdata): add regression test for and-on I'd like to use queries of the form "x and on() (vector(y)==1)" to be able to include and exclude series for dashboards. This helps migration to native histograms in dashboards by using a dashboard variable to set "y" to either -1 or 1 to exclude or include the result. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> --------- Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>	2024-11-20 10:29:18 +01:00
Neeraj Gartia	048222867a	fix count_values for histograms ... Signed-off-by: Neeraj Gartia <neerajgartia211002@gmail.com>	2024-11-20 02:07:31 +05:30
Charles Korn	62e6e55c07	promql: fix issues with comparison binary operations with bool modifier and native histograms (#15413) ... * Fix issue where comparison operations with `bool` modifier and native histograms return histograms rather than 0 or 1 * Don't emit anything for comparisons between floats and histograms when `bool` modifier is used * Don't emit anything for comparisons between floats and histograms when `bool` modifier is used between a vector and a scalar --------- Signed-off-by: Charles Korn <charles.korn@grafana.com>	2024-11-19 09:13:34 +01:00
Charles Korn	45db23617a	promql: fix incorrect "native histogram ignored in aggregation" annotations (#15414) ... Signed-off-by: Charles Korn <charles.korn@grafana.com>	2024-11-19 08:17:49 +01:00
huochexizhan	4f48e76086	chore: fix some function names in comment ... Signed-off-by: huochexizhan <huochexizhan@outlook.com>	2024-11-19 12:02:10 +08:00
zenador	e13c28bd4a	Use a function to determine if an aggregation function is experimental (#15331) ... Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>	2024-11-15 15:09:50 +01:00
Neeraj Gartia	789c9b1a5e	[BUGFIX] PromQL: Corrects the behaviour of some operator and aggregators with Native Histograms (#15245) ... PromQL: Correct the behaviour of some operator and aggregators with Native Histograms --------- Signed-off-by: Neeraj Gartia <neerajgartia211002@gmail.com>	2024-11-12 15:37:05 +01:00
Joshua Hesketh	ed2668bbda	Merge branch 'main' into jhesketh/clamp ... Signed-off-by: Joshua Hesketh <josh@nitrotech.org>	2024-11-12 10:20:58 +11:00
Bartlomiej Plotka	76432aaf4e	Merge pull request #15220 from prometheus/nhcb-scrape-optimize ... perf(nhcb): scrape optimize	2024-11-08 19:02:48 +01:00
Matthieu MOREL	af1a19fc78	enable errorf rule from perfsprint linter ... Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	2024-11-06 16:50:36 +01:00
Bryan Boreham	6979b237b9	Merge branch 'release-2.55' into merge-2.55-into-main2	2024-11-04 12:58:38 +00:00
Ben Ye	b7aca45de7	fix round function ignoring enableDelayedNameRemoval feature flag ... Signed-off-by: Ben Ye <benye@amazon.com>	2024-10-31 00:30:22 -07:00
György Krajcsovits	eafe72a0d0	perf(nhcb): optimize away most allocations in convertnhcb ... In general aim for the happy case when the exposer lists the buckets in ascending order. Use Compact(2) to compact the result of nhcb convert. This is more in line with how client_golang optimizes spans vs buckets. aef8aedb4b/prometheus/histogram.go (L1485) Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>	2024-10-28 08:34:54 +01:00
Jan Fajerski	38fd48e6b5	v2.55.0 ... -----BEGIN SSH SIGNATURE----- U1NIU0lHAAAAAQAAADMAAAALc3NoLWVkMjU1MTkAAAAgX42TrpDUXJbbi9yZ3hs6cDg+kz G6d3nAlAb2XQInrEgAAAADZ2l0AAAAAAAAAAZzaGE1MTIAAABTAAAAC3NzaC1lZDI1NTE5 AAAAQGoSEKIFT/BfavtG2qW9n7NYonNQk/9r6gCLvxln9elt1hiY0ZGcwRhm1QNx6FotxJ Y3LB9dt4s5akB3fOPkYwc= -----END SSH SIGNATURE----- Merge tag 'v2.55.0' into release-3.0.0-rc.0 v2.55.0	2024-10-25 14:16:22 +02:00
Björn Rabenstein	7c7116fea8	Merge pull request #15176 from jhesketh/jhesketh/round ... Round function should ignore native histograms	2024-10-22 19:14:16 +02:00
Alex Greenbank	421a3c22ea	scrape: provide a fallback format (#15136) ... scrape: Remove implicit fallback to the Prometheus text format Remove implicit fallback to the Prometheus text format in case of invalid/missing Content-Type and fail the scrape instead. Add ability to specify a `fallback_scrape_protocol` in the scrape config. --------- Signed-off-by: alexgreenbank <alex.greenbank@grafana.com> Signed-off-by: Alex Greenbank <alex.greenbank@grafana.com> Co-authored-by: Björn Rabenstein <beorn@grafana.com>	2024-10-18 17:12:31 +02:00
Bryan Boreham	754c104a3e	Merge pull request #15173 from prometheus/merge-2.55-into-main-3 ... Merge release-2.55 into main (interim)	2024-10-18 10:28:20 +01:00
Joshua Hesketh	14ef1ce8ab	Round function should ignore native histograms ... As per the documentation, native histograms are skipped. This is in line with other simpleFunc's. Signed-off-by: Joshua Hesketh <josh@nitrotech.org>	2024-10-17 15:39:48 +11:00
Bryan Boreham	a846bf9a5e	Merge branch 'release-2.55' into merge-2.55-into-main-3	2024-10-16 14:08:54 +01:00
Joshua Hesketh	5a4e4f6936	Fix stddev/stdvar when aggregating histograms, NaNs, and infinities (#14941) ... promql: Fix stddev/stdvar when aggregating histograms, NaNs, and Infs Native histograms are ignored when calculating stddev or stdvar. However, for the first series of each group, a `groupedAggregation` is always created. If the first series that was encountered is a histogram then it acts as the equivalent of a 0 point. This change creates the first `groupedAggregation` with the `seen` field set to `false` if the point is a histogram, thus ignoring it like the rest of the aggregation function does. A new `groupedAggregation` will then be created once an actual float value is encountered. This commit also sets the `floatValue` field of the `groupedAggregation` to `NaN`, if the first float value of a group is `NaN` or `±Inf`, so that the outcome is consistently `NaN` once those values are in the mix. (The added tests fail without this change). Signed-off-by: Joshua Hesketh <josh@nitrotech.org> Signed-off-by: beorn7 <beorn@grafana.com> --------- Signed-off-by: Joshua Hesketh <josh@nitrotech.org> Signed-off-by: beorn7 <beorn@grafana.com> Co-authored-by: beorn7 <beorn@grafana.com>	2024-10-16 15:00:46 +02:00
Arve Knudsen	de16f5e387	[FEATURE] PromQL: Add experimental info function MVP (#14495) ... The `info` function is an experiment to improve UX around including labels from info metrics. `info` has to be enabled via the feature flag `--enable-feature=promql-experimental-functions`. This MVP of info simplifies the implementation by assuming: * Only support for the target_info metric * That target_info's identifying labels are job and instance Also: * Encode info samples' original timestamp as sample value * Deduce info series select hints from top-most VectorSelector --------- Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> Co-authored-by: Ying WANG <ying.wang@grafana.com> Co-authored-by: Augustin Husson <augustin.husson@amadeus.com> Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com> Co-authored-by: Björn Rabenstein <github@rabenste.in> Co-authored-by: Bryan Boreham <bjboreham@gmail.com>	2024-10-16 13:52:11 +01:00
Arve Knudsen	e05e97cdd7	evaluator.rangeEval: Split out gatherVector method ... Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>	2024-10-16 14:01:03 +02:00