Levi Harrison
3b4cbf8da4
Inject readiness state through context ( #11617 )
...
Signed-off-by: Levi Harrison <git@leviharrison.dev>
Signed-off-by: Levi Harrison <git@leviharrison.dev>
2023-01-09 00:04:00 +01:00
György Krajcsovits
069ceeaefb
Fix linter errors after linter update
...
Updated linter golangci-lint from 1.45 to 1.50 previously
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
2023-01-08 17:10:18 +01:00
Levi Harrison
5a485e15ea
Merge pull request #11822 from krajorama/krajo
...
Fix comment
2023-01-08 11:06:53 -05:00
György Krajcsovits
1fb0c8b688
Sync golangci-lint version with upstream
...
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
2023-01-08 17:00:05 +01:00
György Krajcsovits
f2bf0f0303
Fix gofumpt linter error
...
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
2023-01-08 16:48:27 +01:00
György Krajcsovits
a9ed61e91f
Fix goftm linter error
...
How was this not inherited from upstream???
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
2023-01-08 16:39:27 +01:00
György Krajcsovits
97626c9583
Fix comment
...
Comment was not updated when code changed from labels to builder
in #11717
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
2023-01-08 16:29:02 +01:00
György Krajcsovits
d524ab48b1
Fixes after merge
...
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
2023-01-08 16:13:36 +01:00
György Krajcsovits
103c4fd289
Merge remote-tracking branch 'upstream/main' into main
...
# Conflicts:
# .github/workflows/ci.yml
# tsdb/block.go
# tsdb/compact.go
# tsdb/compact_test.go
# tsdb/head_read.go
# tsdb/index/index.go
# tsdb/ooo_head_read.go
# tsdb/querier_test.go
2023-01-08 14:55:44 +01:00
Ganesh Vernekar
57cab58c53
Merge pull request #11774 from codesome/rules-ooo
...
rules: Consider ErrTooOldSample in expected errors
2023-01-06 14:56:14 +05:30
Björn Rabenstein
c49a28bb97
Merge pull request #11782 from codesome/floatappendabletest
...
tsdb: Improve TestFloatHistogramChunkAppendable and TestHistogramChunkAppendable
2023-01-05 17:15:10 +01:00
Saeid Bostandoust
da6c014039
update ServiceAccount for new kubernetes versions
...
Signed-off-by: Saeid Bostandoust <49065072+ssbostan@users.noreply.github.com>
2023-01-05 15:43:48 +00:00
beorn7
b5d4a94e9d
textparse: Add gauge histogram support to protobuf parsing
...
With this commit, the parser stops to see a gauge histogram (whether
native or conventional) as an unexpected metric type. It ingests it
normally, it even sets the `GaugeHistogram` type in the metadata (as
it has already done for a conventional gauge histogram scraped using
OpenMetrics), but it otherwise treats it as a normal counter-like
histogram.
Once #11783 is merged, though, it should be very easy to utilize the
type information.
Signed-off-by: beorn7 <beorn@grafana.com>
2023-01-05 15:39:10 +01:00
beorn7
e9d9bb1b08
textparse: Handle unknown metric types in protobuf gracefully
...
So far, the parser hasn't validated that the type is valid in the
`Next()` call. Later, in the `Series()` call, however, it assumes that
we will only see valid types and therefore panics with `encountered
unexpected metric type, this is a bug`.
This commit fixes said bug by adding validation to the `Next()` call.
Signed-off-by: beorn7 <beorn@grafana.com>
2023-01-05 15:21:18 +01:00
Bryan Boreham
e61348d9f3
tsdb/index: fast-track postings for label=""
...
We need to special-case ""="" too, which is used in some tests to mean "everything".
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2023-01-05 14:05:54 +00:00
Bryan Boreham
cf92cd2688
tsdb: sort values for Postings only when required
...
In the head and in v1 postings on disk, it makes no difference whether
postings are sorted. Only for v2 does the code step through in order.
So, move the sorting to where it is required, and thus skip it entirely
in the head.
Label values in on-disk blocks are already sorted, but `slices.Sort` is
very fast on already-sorted data so we don't bother checking.
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2023-01-05 14:05:54 +00:00
Bryan Boreham
80ac0d7c82
promql: add benchmark for match against blank string
...
Blank strings are not handled efficiently by tsdb.
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2023-01-05 14:05:54 +00:00
Ganesh Vernekar
f1a332c496
rules: Consider ErrTooOldSample in expected errors
...
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
2023-01-05 14:49:30 +05:30
Ganesh Vernekar
7ed1ddb338
tsdb: Improve TestHistogramChunkAppendable and add new cases
...
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
2023-01-05 14:44:24 +05:30
Ganesh Vernekar
fa0f04bbc6
Merge pull request #11805 from bboreham/fix-benchmark-intersect
...
tsdb/index: fix BenchmarkIntersect to do work on each loop
2023-01-04 18:19:14 +05:30
Bryan Boreham
d228d1d9cc
scrape: remove 'mets' string completely
...
This makes all usage of maps in scrape.go consistent.
Also remove comment about unsafe strings, since we don't use them any
more in this package.
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2023-01-04 12:05:58 +00:00
Aleksey Smirnov
84c6f0e584
Init value for useState hook calls once ( #11802 )
...
Signed-off-by: Smirnov Aleksey <aleksey.smirnov@sbermarket.ru>
Signed-off-by: Smirnov Aleksey <aleksey.smirnov@sbermarket.ru>
Co-authored-by: Smirnov Aleksey <aleksey.smirnov@sbermarket.ru>
2023-01-03 22:09:00 +01:00
Bryan Boreham
3da2c99ffd
tsdb/index: don't call ExpandPostings in a benchmark
...
This allocates memory for all the returned values, which skews the
result. We aren't trying to benchmark `ExpandPostings`, so just step
through all the values without storing them to consume them.
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2023-01-03 15:26:29 +00:00
Bryan Boreham
4931983ca9
tsdb/index: make BenchmarkIntersect do work on each loop
...
Previously all the postings constructed were consumed on the first
iteration, so subsequent iterations did no work.
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2023-01-03 15:25:38 +00:00
Björn Rabenstein
432ea873c3
Merge pull request #11778 from codesome/float-iso
...
Staleness handling for FloatHistogram
2023-01-03 13:31:12 +01:00
Levi Harrison
15492d7100
Merge pull request #11681 from dgrisonnet/fix-tokens
...
Fix error output of the Prometheus parser to display the right tokens
2023-01-02 16:04:20 -05:00
dependabot[bot]
2a9fb757a9
Bump github.com/hetznercloud/hcloud-go from 1.38.0 to 1.39.0 ( #11800 )
...
Bumps [github.com/hetznercloud/hcloud-go](https://github.com/hetznercloud/hcloud-go ) from 1.38.0 to 1.39.0.
- [Release notes](https://github.com/hetznercloud/hcloud-go/releases )
- [Changelog](https://github.com/hetznercloud/hcloud-go/blob/main/CHANGELOG.md )
- [Commits](https://github.com/hetznercloud/hcloud-go/compare/v1.38.0...v1.39.0 )
---
updated-dependencies:
- dependency-name: github.com/hetznercloud/hcloud-go
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-01-02 15:59:47 -05:00
Saeid Bostandoust
3c468cd4e8
update ServiceAccount for new kubernetes versions
...
Signed-off-by: Saeid Bostandoust <49065072+ssbostan@users.noreply.github.com>
2023-01-02 14:17:11 +00:00
Damien Grisonnet
96b9d8cebb
model/textparse: associate correct token to errors
...
In some cases, the Prometheus HTTP format parser was not returning the
right token in the error output which made debugging impossible.
Signed-off-by: Damien Grisonnet <dgrisonn@redhat.com>
2023-01-02 13:57:27 +01:00
dependabot[bot]
efd1392ec8
Bump github.com/influxdata/influxdb
...
Bumps [github.com/influxdata/influxdb](https://github.com/influxdata/influxdb ) from 1.10.0 to 1.11.0.
- [Release notes](https://github.com/influxdata/influxdb/releases )
- [Changelog](https://github.com/influxdata/influxdb/blob/master/CHANGELOG_OLD.md )
- [Commits](https://github.com/influxdata/influxdb/compare/v1.10.0...v1.11.0 )
---
updated-dependencies:
- dependency-name: github.com/influxdata/influxdb
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2023-01-01 23:04:14 +00:00
Levi Harrison
89539c35c9
Remove nomad datacenter
field in configuration docs
...
Signed-off-by: Levi Harrison <git@leviharrison.dev>
2022-12-29 14:18:42 -05:00
Oleg Zaytsev
98dee9f384
Merge pull request #377 from grafana/shortcut-postings-for-matchers
...
Shortcut postings for matchers when empty postings are selected
2022-12-29 17:16:52 +01:00
Arve Knudsen
6fc69c8251
Merge pull request #379 from grafana/fix-typo
...
tsdb: Fix typo in comment
2022-12-29 16:56:04 +01:00
Fish-pro
6ed71a229e
Use errors.Is to check for a specific error
...
Signed-off-by: Fish-pro <zechun.chen@daocloud.io>
2022-12-29 23:23:07 +08:00
Arve Knudsen
41dc53ea16
tsdb: Fix typo in comment
...
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
2022-12-29 15:41:20 +01:00
Oleg Zaytsev
fa868fd321
Merge pull request #378 from grafana/allow-forcing-usage-of-postings-for-matchers-cache
...
Allow forcing usage of PostingsForMatchersCache
2022-12-29 13:44:15 +01:00
Oleg Zaytsev
e246ce436d
s/IsEmptyPostings/IsEmptyPostingsType/
...
Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
2022-12-29 13:43:42 +01:00
Ganesh Vernekar
b42802af9a
tsdb: Improve TestFloatHistogramChunkAppendable and add new cases
...
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
2022-12-28 21:07:47 +05:30
Marc Tudurí
49f775d8a0
histograms: Add missing float histograms tests for PromQL ( #11780 )
...
* test: TestSparseHistogramRate
* test: TestSparseHistogram_HistogramQuantile
* test: TestSparseHistogram_HistogramFraction
* test: TestSparseHistogram_HistogramFraction
* test: TestSparseHistogram_Sum_Count_AddOperator
* test: TestSparseHistogram_HistogramCountAndSum
* tests: fix TestSparseHistogram_HistogramCountAndSum
* linter
* refactor TestSparseHistogram_HistogramCountAndSum
* wrap TestSparseHistogram_HistogramCountAndSum
Signed-off-by: Marc Tuduri <marctc@protonmail.com>
2022-12-28 19:15:47 +05:30
Oleg Zaytsev
d23859dee2
Allow forcing usage of PostingsForMatchersCache
...
When out-of-order is enabled, queries go through both Head and OOOHead,
and they both execute the same PostingsForMatchers call, as memSeries
are shared for both.
In some cases these calls can be heavy, and also frequent. We can
deduplicate those calls by using the PostingsForMatchers cache that we
already use for query sharding.
The usage of this cache can skip a newly appended series in the results
for the duration of the ttl.
Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
2022-12-28 13:44:10 +01:00
Ganesh Vernekar
c155c0e312
tsdb: Test staleness handling of FloatHistogram
...
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
2022-12-28 14:48:56 +05:30
Ganesh Vernekar
2820e327db
tsdb: Add staleness handling for FloatHistogram
...
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
2022-12-28 14:48:39 +05:30
Ganesh Vernekar
e555469ba1
tsdb: Remove isHistogramSeries from memSeries
...
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
2022-12-28 14:31:55 +05:30
Marc Tudurí
9474610baf
Support FloatHistogram in TSDB ( #11522 )
...
Extends Appender.AppendHistogram function to accept the FloatHistogram. TSDB supports appending, querying, WAL replay, for this new type of histogram.
Signed-off-by: Marc Tudurí <marctc@protonmail.com>
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
Co-authored-by: Ganesh Vernekar <ganeshvern@gmail.com>
2022-12-28 14:25:07 +05:30
Oleg Zaytsev
f3d001df2e
Add shortcuts for empty postings
...
Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
2022-12-27 18:13:56 +01:00
Oleg Zaytsev
ae02ffd5ae
Add more benchmark cases
...
Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
2022-12-27 16:42:05 +01:00
Ganesh Vernekar
ae72c752a1
Merge pull request #11766 from bboreham/agg-reuse-labelbuilder
...
Promql: reuse LabelBuilder in aggregations
2022-12-27 18:37:41 +05:30
Bryan Boreham
1b0a29701b
promql: optimise aggregation with no labels
...
For a query like 'sum (foo)', we can quickly skip to the empty labels that its result needs.
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2022-12-23 13:33:14 +00:00
Bryan Boreham
aafef011b7
Promql: reuse LabelBuilder in aggregations
...
We have a LabelBuilder in EvalNodeHelper; use it instead of creating a new one at every step.
Need to take some care that different uses of enh.lb do not overlap.
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2022-12-23 13:21:29 +00:00
Bryan Boreham
2c382f5e24
promql: extract function to initialize LabelBuilder
...
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2022-12-23 13:21:22 +00:00