Atibhi Agrawal
0dd6e0cb76
change string(model.metricnamelabel) to model.metricnamelabel ( #8289 )
...
Signed-off-by: aSquare14 <atibhi.a@gmail.com>
2020-12-15 20:17:31 +05:30
Brian Brazil
bef9d4e182
Don't include rendered expression in parse errors. ( #8177 )
...
For a sufficiently complex expression, having to render
thousands of nodes for every subquery type error can take
a while - so don't do that.
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>
2020-11-12 15:25:52 +01:00
Julien Pivotto
6c56a1faaa
Testify: move to require ( #8122 )
...
* Testify: move to require
Moving testify to require to fail tests early in case of errors.
Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
* More moves
Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
2020-10-29 09:43:23 +00:00
Julien Pivotto
1282d1b39c
Refactor test assertions ( #8110 )
...
* Refactor test assertions
This pull request gets rid of assert.True where possible to use
fine-grained assertions.
Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
2020-10-27 11:06:53 +01:00
Julien Pivotto
4e5b1722b3
Move away from testutil, refactor imports ( #8087 )
...
Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
2020-10-22 11:00:08 +02:00
Harkishen Singh
fc8e769d71
Use ASSIGN when using = inside braces ( #7911 )
...
* Fix EQL when using = inside braces.
Signed-off-by: Harkishen-Singh <harkishensingh@hotmail.com>
* EQL => EQLC and ASSIGN => EQL
Signed-off-by: Harkishen-Singh <harkishensingh@hotmail.com>
* Aligned yacc code.
Signed-off-by: Harkishen-Singh <harkishensingh@hotmail.com>
2020-09-09 15:40:02 +05:30
johncming
267dd17fe7
promql/parser: use pos instead of origin. ( #7853 )
...
Signed-off-by: johncming <johncming@yahoo.com>
2020-08-26 15:26:26 +05:30
Julien Pivotto
d867491364
Human-friendly durations in PromQL ( #7713 )
...
* Add support for user-friendly durations
Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
2020-08-04 21:12:41 +02:00
johncming
31929b83d5
promql: use explicit type declare instead of string. ( #7716 )
...
Signed-off-by: johncming <johncming@yahoo.com>
2020-08-02 09:57:38 +01:00
Owen Diehl
00b7bdb1b6
parser.{Expr,Statement} publicly implementable ( #7639 )
...
* parser.{Expr,Statement} publicly implementable
Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
2020-07-25 09:05:58 +01:00
Guangwen Feng
6b7ac2ac1b
Add unit test case to improve test coverage for matcher.go ( #7658 )
...
Signed-off-by: Guangwen Feng <fenggw-fnst@cn.fujitsu.com>
2020-07-24 11:21:42 +01:00
Guangwen Feng
b30654211c
Fix incorrect arguments order in TestExprString ( #7602 )
...
Signed-off-by: Guangwen Feng <fenggw-fnst@cn.fujitsu.com>
2020-07-17 13:38:04 +01:00
Tobias Guggenmos
1f73073d73
Make without a valid metric identifier ( #7533 )
...
Discussion see #7532 .
cc @juliusv
Signed-off-by: Tobias Guggenmos <tobias.guggenmos@uni-ulm.de>
2020-07-08 12:58:12 +02:00
Julien Pivotto
72425d4e3d
Add group() aggregator ( #7480 )
...
* Add group() aggregator
Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
2020-06-30 16:51:18 +02:00
Guangwen Feng
9ab072b470
Fix golint issue caused by typo ( #7475 )
...
Signed-off-by: Guangwen Feng <fenggw-fnst@cn.fujitsu.com>
2020-06-28 11:03:09 +01:00
Julien Pivotto
1f6f8e60ee
promql/parser: Cleanup generatedParserResult accross reuse
...
Reusing the same generatedParserResult ends up in strange panics:
See #7131 and #7127 .
Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
2020-04-16 01:51:08 +02:00
Ben Kochie
269e7c8091
Fix golint issues.
...
Signed-off-by: Ben Kochie <superq@gmail.com>
2020-03-23 20:38:43 +01:00
johncming
bdc45c2b9e
remove unused code. ( #7019 )
...
Signed-off-by: johncming <johncming@yahoo.com>
2020-03-21 07:15:51 +00:00
Tobias Guggenmos
012161d90d
PromQL: Fix lexer error handling ( #6958 )
...
* PromQL: Fix lexer error handling
This fixes bugs in the handling of lexer errors that are only noticeable for users of the language server and caused https://github.com/prometheus-community/promql-langserver/issues/104 .
Signed-off-by: Tobias Guggenmos <tobias.guggenmos@uni-ulm.de>
* Add test for error position ranges
Signed-off-by: Tobias Guggenmos <tobias.guggenmos@uni-ulm.de>
2020-03-16 15:47:47 +01:00
Julien Pivotto
5ddd1dcf0f
Fix panic when parsing varags ( #6940 )
...
Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
2020-03-08 13:09:24 +01:00
Tobias Guggenmos
1dbd799354
PromQL: Fix regression tests ( #6935 )
...
This PR fixes the regression tests for the issue fixed in #6931 .
The reason for that is that all of the invalid queries that triggered the regression have become more or less valid syntax in #6933 (they might still fail typechecking).
Signed-off-by: Tobias Guggenmos <tobias.guggenmos@uni-ulm.de>
2020-03-06 08:17:01 +00:00
Brian Brazil
44ad28dd5e
PromQL: Allow more keywords as metric names ( #6933 )
...
* Allow more keywords as metric names
* Add documentation about forbidden keywords
Signed-off-by: Tobias Guggenmos <tobias.guggenmos@uni-ulm.de>
2020-03-05 13:20:53 +00:00
Brian Brazil
7164b58945
PromQL: Fix parser panic ( #6931 )
...
Signed-off-by: Tobias Guggenmos <tobias.guggenmos@uni-ulm.de>
2020-03-05 08:03:38 +00:00
LongKB
82f7ed208b
Remove some duplicated words ( #6882 )
...
Signed-off-by: Pham Duc Hanh <hanhpd@fujitsu.com>
2020-02-27 07:08:31 +01:00
Tobias Guggenmos
ec3df53f78
Add nolint comment
...
Signed-off-by: Tobias Guggenmos <tguggenm@redhat.com>
2020-02-17 16:09:23 +01:00
Tobias Guggenmos
6c00f2ffcb
Comment fixes
...
Signed-off-by: Tobias Guggenmos <tguggenm@redhat.com>
2020-02-17 16:09:23 +01:00
Tobias Guggenmos
1360f9ff12
Fix all build errors in promql package
...
Signed-off-by: Tobias Guggenmos <tguggenm@redhat.com>
2020-02-17 16:09:23 +01:00
Tobias Guggenmos
9a1366775e
Store function implementations independently of their signatures
...
Signed-off-by: Tobias Guggenmos <tguggenm@redhat.com>
2020-02-17 16:07:53 +01:00
Tobias Guggenmos
ff0ea1c1ac
Fix more identifiers
...
Signed-off-by: Tobias Guggenmos <tguggenm@redhat.com>
2020-02-17 16:07:53 +01:00
Tobias Guggenmos
6b1b323558
Export sequenceValue
...
Signed-off-by: Tobias Guggenmos <tguggenm@redhat.com>
2020-02-17 16:07:53 +01:00
Tobias Guggenmos
65f5b9827d
Rename package
...
Signed-off-by: Tobias Guggenmos <tguggenm@redhat.com>
2020-02-17 16:05:21 +01:00
Tobias Guggenmos
98a9b7c90c
Remove engine specific types
...
Signed-off-by: Tobias Guggenmos <tguggenm@redhat.com>
2020-02-17 16:05:21 +01:00
Tobias Guggenmos
e7c2716f55
Move files
...
Signed-off-by: Tobias Guggenmos <tguggenm@redhat.com>
2020-02-17 16:05:21 +01:00